Migrate docker module to moby - #909
Open
AndrewFerr wants to merge 3 commits into
Open
Conversation
Migrate from the deprecated github.com/docker/docker module to the current latest version of github.com/moby/moby, and make all changes necessary to adapt to its refactoring.
reivilibre
approved these changes
Aug 5, 2026
| return "", fmt.Errorf("%s: failed to create docker network. %w", blueprintName, err) | ||
| } | ||
| if nw.Warning != "" { | ||
| if len(nw.Warning) > 0 && nw.Warning[0] != "" { |
Contributor
There was a problem hiding this comment.
wondering why we have to check [0] != "" as well. Is it actually necessary?
I don't mind and I don't know, just seems bizarre to me
Member
Author
There was a problem hiding this comment.
I don't know if it's necessary either, but figured it was cheap to guard against it just in case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from the deprecated github.com/docker/docker module to the current latest version of github.com/moby/moby, and make all changes necessary to adapt to its refactoring.
Signed-off-by: Andrew Ferrazzutti [email protected]
Pull Request Checklist