Repository navigation
Delete AppClient methods no build calls (#2782) - #3274
Merged
Merged
Conversation
Eleven AppClient methods had no caller in any build: production, tests, hosts, simulator, incident replay or the campaign runner. Each has a MarmotAppRuntime method of the same name that hosts already call, which reaches the same client helper through the account worker. The remaining 18 test-only methods keep their dead-code allowance: none has a production caller. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 18 minutes. View limit details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since #3268,
AppClientis public only undertest-support. Eleven of its methods had no caller in any build: noproduction path, test, host, simulator, incident replay or campaign runner calls them. A dead-code allowance was the
only thing keeping them from warnings. Nobody outside the codebase is affected.
Fix
Delete the eleven. Hosts already call a
MarmotAppRuntimemethod of the same name for each one, and that methodreaches the same client helper through the account worker, so no behaviour loses its only route. The other eighteen
methods with the allowance are called only by tests. The default build still reports each of them as unused, so they
keep the allowance.
Verification
cargo check --all-targets --all-features --keep-goingover marmot-app, wn-cli, marmot-uniffi, marmot-c, the simulator, incident-replay, the campaign runner and agent-connector. The same eleven methods had no caller.cargo clippy -p marmot-app -- -D warningson the lib,--all-targetsand--all-targets --all-features, plus--all-targets --all-featuresover those eight cratestest-policy-overridespublic_app_03+ process adapters; wn-cli DM workflow + daemon)just c-header(marmot.hbyte-identical),just binding-docs-gate,just naming-gate,cargo fmt --all --checkPart of #2782
🤖 Generated with Claude Code