Repository navigation
feat(show-dont-tell): a PR with a serve command carries a paste-ready "Try it" block - #80
Merged
Merged
Conversation
… "Try it" block parseConfig reads checkout/install/serve; tryItBlock renders the block; scanTryIt checks the body; report goes red when serve is set, a rendered path is touched and the block is missing, printing the expected block. Co-Authored-By: Claude Fable 5.1 <[email protected]>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Duplication: 0 new clones, 4 new repeated literals
New repeated literals
Scanned the whole tree, f03fc6c against 0c400cb. A measurement, not a gate. |
Complexity: +16 across 9 functions
All metrics
Measured 2 changed files, f03fc6c against 0c400cb. A measurement, not a gate. |
|
Claude finished @mark-brannan's task in 1m 24s —— View job Review of PR #80🤖 No blockers. The security surface is unchanged, and I left four small inline fixes. Security surface
Inline findings (each gives the exact fix)
Checked and correct
Not run: The rubric doesn't apply: the PR adds no README, docs or SKILL.md prose. There were no prior threads. 🤖 claude-opus-5-5 · - · - |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This was referenced Oct 17, 2026
|
Claude finished @mark-brannan's task in 15s —— View job Review of PR #80 (new commit ab5fc1c)🤖 No new findings. The security surface is still unchanged (no All four earlier threads are covered by this commit or by your ruling:
I did not run the tests: this runner can't execute |
…t documented Review threads on #80: fetch repos/$REPO/pulls/$PR once and take body and head.sha from it; report returns a one-line why so the ::error:: annotation names the rule that failed (no Try it block / neither / no image); the workflow comment says checkout: defaults to ~/<repo name>. The unused repo parameter of tryItBlock stays, per Solace's thread: the API is kept wide for later. Co-Authored-By: Claude Fable 5.1 <[email protected]>
Owner
Author
|
@Mergifyio queue |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
A repo whose
.github/show-dont-tell.ymlsetsserve:now owes every PR that touches a rendered path a paste-ready "Try it" block, on top of the existing picture-or-URL rule.parseConfigalso reads scalar keyscheckout:,install:,serve:(quotes and#comments tolerated; lists unchanged; keys absent when not set).tryItBlock({ repo, pr, head, checkout, install, serve })renders the block;{port}becomes 10000 + PR number, install step omitted when empty.scanTryIt(body, pr): true when aTry itheading is followed by text containingpull/<pr>/head. Fences are not stripped (the command is the deliverable).report/main: withserveset and rendered paths matched, red whenscanTryItfails. The red summary prints the expected block; the body and the head SHA come from onegh api repos/$REPO/pulls/$PRread.reportalso returns a one-linewhy, printed as the::error::annotation, so the reason names the rule that failed. Green and "no rendered path" paths unchanged; withoutservethe check behaves as before.The block (searoom, PR 221)
Tested
node --test .github/scripts/show-dont-tell.test.mjs: 14 pass, 0 fail. New tests cover the scalar keys, the threewhywordings, exact block output (byte-for-byte against the spec), empty install and repeated{port},scanTryItcases, and report's red-with-serve cases (shown but no block; neither) plus the unchanged green paths. Themainnetwork path (head SHA fetch) is not exercised by unit tests.Pencil: none
Head: ab5fc1c
🤖 Generated with Claude Code · claude-sonnet-5-5 · medium · 9aaeb018 · fixes: claude-fable-5-1 · - · a991ebca