Repository navigation
feat(show-dont-tell): require an image or preview URL when rendered paths change - #78
Merged
Merged
Conversation
…s shows an image or preview URL Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Duplication: 2 new clones, 4 new repeated literals
New clones
New repeated literals
Scanned the whole tree, e1b177b against 0482d5b. A measurement, not a gate. |
Complexity: +33 across 19 functions
All metrics
Measured 2 changed files, e1b177b against 0482d5b. A measurement, not a gate. |
|
Claude finished @mark-brannan's task in 1m 13s —— View job Review: show-dont-tellThere are three inline findings. Two of them let a PR that touches a rendered path go green without showing anything.
Security checks (the ones this repo asks for):
Not verified: I couldn't run the test suite because |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
…ted lists, ignore code spans Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
|
Claude finished @mark-brannan's task in 24s —— View job Review: show-dont-tell (after the fix push)The three earlier findings are fixed in this push: config read at the base SHA, unindented list items accepted, and code spans and fences stripped before the image scan. I did not re-raise them. There is one new finding, inline at
Security checks:
Not verified: I did not run the test suite. This review comes from reading the code. |
…n either The code-span strip covered the image scan only; the URL scan still read the raw body, so a fenced example URL counted as a preview. Co-Authored-By: Claude Fable 5.1 <[email protected]>
|
Claude finished @mark-brannan's task in 16s —— View job Review: show-dont-tell (after c347521)No new findings. The one open item from the last review, the URL scan reading Security checks:
Not verified: |
… prefix Without urls:, any https link off github.com satisfied the check, and every agent-written PR body carries one: the attribution link https://claude.com/claude-code. The check would never have fired on an agent PR. Now only an image counts unless urls: names the repo's preview prefixes; the red message drops the link hint when none are named. Co-Authored-By: Claude Fable 5.1 <[email protected]>
|
Claude finished @mark-brannan's task in 17s —— View job Review: show-dont-tell (after 047ba9c)One finding, on the PR description, not the code. No inline comments.
The code, tests and the workflow header comment agree with each other. The new Security checks:
Not verified: I did not run the test suite. |
…st against Co-Authored-By: Claude Fable 5.1 <[email protected]>
Owner
Author
|
🤖 Critical review. One hole the earlier passes missed, fixed in 047ba9c: without 🤖 claude-fable-5-1 · - · 4371c500 |
…own either A PR template's placeholder (<!-- drop a screenshot here:  -->) survives into every body written over it and counted as an image. Comments are stripped with code spans and fences before the scan, with tests. Co-Authored-By: Claude Fable 5.1 <[email protected]>
Owner
Author
|
🤖 Critical review, second pass. One gap the earlier passes missed, fixed in c0eae14: an image or URL inside an HTML comment counted as shown, so a PR template's placeholder ( 🤖 claude-fable-5-1 · - · 22d27a82 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
show-dont-tell
Reusable check for the "yes, full stop" ruling (RCA round 2, item 3): in an opted-in repo, a PR touching a rendered path must carry an image or a preview URL in its description, else red. Opt-in is a per-repo file; no file, no check.
Caller (the trigger types make a description edit re-run it):
Opt-in file
.github/show-dont-tell.ymlin the calling repo:Satisfied by an inline image (
,<img src>, a user-attachments upload) or a link starting with one of theurls:prefixes. Withurls:absent only an image counts. An image or URL inside a code span, a fence or an HTML comment (a template placeholder) does not count. The body is read live from the API. The summary names the matched paths when red; "no rendered path touched" when green with no match.Cost: node built-ins only, no install step; its own job. Measured:
show-dont-tell-tests4 s per push, the whole CI run green: https://github.com/mark-brannan/.github/actions/runs/39008635039 . The reusable workflow reads the opt-in file at the PR base (a PR cannot exempt itself), and costs a few seconds in a caller (no install, no checkout of the caller).Pencil:
urls:; withouturls:only an image counts. The first draft accepted any https link off github.com, and the agent attribution linkhttps://claude.com/claude-codein every agent-written body met it, so the check would never have fired on an agent PR. Undo: revert 047ba9c. decisions logHead: c0eae14
🤖 Generated with Claude Code
🤖 claude-sonnet-5-5 · medium · 2f08b81b, then claude-fable-5-1 · - · 4371c500, then claude-fable-5-1 · - · 22d27a82