Repository navigation
feat: expose GlobalErrorHandler to Swift and Kotlin - #2029
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds public
GlobalErrorHandler.reportErrorAPIs for SwiftErrorand KotlinThrowable, covering all six error sources. Swift aliases the C++ErrorSourceenum withSWIFT_NAMEcase names. Kotlin callbacks now use the public API. Reporting keeps the existing debug-only logging behavior.Validated with Kotlin compilation, Android NDK compilation, formatting, and external Swift/JNI debug and release smoke tests covering every source and Unicode error messages. Swift checks also cover enum type identity, exhaustive switches, and
Sendableuse. Full runtime suites were not run because this checkout lacks the Hermes submodule.