Repository navigation
test: reproduce callback struct metadata collision in standalone tests - #2012
Merged
mrousavy merged 1 commit intoOct 28, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Member
Author
|
Agents suggestion to address this: |
hannojg
changed the title
mrousavy
marked this pull request as ready for review
October 28, 2026 10:49
mrousavy
changed the base branch from
v1
to
hannojg/fix-swift-struct-callback-metadata
October 28, 2026 10:50
mrousavy
force-pushed
the
hannojg/repro-callback-metadata
branch
from
October 28, 2026 10:51
efaeced to
80f223b
Compare
mrousavy
marked this pull request as draft
October 28, 2026 10:52
mrousavy
force-pushed
the
hannojg/repro-callback-metadata
branch
from
October 28, 2026 10:52
80f223b to
809aae7
Compare
mrousavy
marked this pull request as ready for review
October 28, 2026 10:52
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a callback-bearing struct to
nitro-test-externalwith the same callback signature asJsStyleStructinnitro-test. The normal iOS test build now reproduces the duplicate Swift metadata error.The new interop case round-trips a native callback through both modules, runs GC, then invokes the returned callback across all four implementation pairs.
The iOS build and all 11 JavaScript suites pass with the fix: