Skip to content

[No QA] Combine PGO tooling and emulator CI verification - #34

Draft
chrispader wants to merge 86 commits into
mainfrom
@chrispader/perf/pgo-ci-verification
Draft

chrispader wants to merge 86 commits into
mainfrom
@chrispader/perf/pgo-ci-verification

Conversation

@chrispader

@chrispader chrispader commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Verifying the PGO flow across separate PRs requires manual device setup and account access. This PR combines the PGO tooling with hosted Android and iOS emulator jobs and a bundled synthetic workload, so an engineer can verify the native build and profile cycle without that setup.

cc @mountiny @roryabraham

Explanation of Change

This combines App #97808, Mobile-Expensify #14046, evaluation tooling #33 and CI #32 for verification. The individual task PRs remain the merge plan.

The workflow builds baseline and instrumented apps, collects three synthetic training runs, merges their native profiles, builds optimized apps, and runs both variants. Emulator results verify this cycle and do not select deployment artifacts or establish phone performance.

Fixed Issues

$ Expensify#98008
PROPOSAL: Expensify#98008
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/14046

Tests

  1. Confirm that Expensify/App has its existing OS_BOTIFY_TOKEN and MAPBOX_SDK_DOWNLOAD_TOKEN repository Actions secrets. The checkout token needs read access to Mobile-Expensify.

  2. Copy both branches with the script below. It pushes the pinned native commit first, then the App branch, which starts CI automatically.

    git clone --single-branch --branch @chrispader/perf/pgo-ci-verification [email protected]:margelo/Expensify.git expensify-pgo-ci
    cd expensify-pgo-ci
    ./scripts/pgo/copy-ci-preview.sh
  3. Open Expensify/App → Actions → Verify native PGO on emulators. Confirm both jobs pass, and inspect pgo-emulator-android and pgo-emulator-ios for the reports and profiles. Use Re-run jobs to repeat the run. The run guide explains the results.

No device registration, signing credentials, test account, environment files or local dependency install are required.

  • Verify that no errors appear in the JS console

Offline tests

The verification workload uses bundled data. Native dependency downloads require network access; a failed download must fail the job without reporting a successful verification.

QA Steps

This workflow has no behavior to test in a staging or production app. An engineer can verify it in Actions using the steps above.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Normal App screens are unchanged. The synthetic verification app runs through a separate CI entry point.

@chrispader chrispader changed the title [No QA] Combine native PGO tooling and CI for verification [No QA] Combine PGO tooling and emulator CI verification Oct 21, 2026
chrispader and others added 6 commits October 21, 2026 19:09
The pinned android-emulator-runner commit came from its main branch,
which does not ship node_modules, so the action failed to load
@actions/core. Release commits bundle their dependencies.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
The app project reaches Maven Central only through repo.grails.org.
Hosted runners start with an empty Gradle cache, so the emulator build
sent every lookup there and Gradle failed with HTTP 429 while resolving
the Node.js download. The emulator init script now points that
repository at Maven Central, which it only mirrors for this build.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
R8 ran out of its 4 GB heap on the hosted Android runner, which also
runs the emulator. It only shrinks Java and Kotlin code, which native
PGO does not change, so the disposable emulator builds now skip it.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
FullStory transforms the release APK, so its excluded task is the one
that writes the final APK listing. On a clean checkout, AGP's
createReleaseApkListingFileRedirect task then fails because that listing
does not exist. Local builds passed only because an earlier build had
left the file behind. The redirect only serves Android Studio, so builds
that exclude FullStory now skip it too.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant