Repository navigation
fix: Print Density Target acts only under Auto Density - #1488
Merged
Merged
Conversation
anchor_target_density also set the fixed curve geometry: the manual exposure pivot, the paper S-curve centre, the Zone Density and regional CMY centres, and the slide zone geometry. A retuned target so changed frames with Auto Density off. A fixed reference_print_density (0.75) now holds the geometry. The tunable target is read only where a metered anchor is placed (compute_pivot, Shadow Reach), and the auto Density slider value folds it in so a bake prints the same. The saved key is unchanged. THUMBNAIL_RENDER_VERSION 15 -> 16 for installs with a retuned target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Print Density Target (Set Targets) changed the render of frames with Auto Density off.
anchor_target_densityalso set the fixed curve geometry: the manual exposure pivot, the paper S-curve centre, the Zone Density, Split Grade and regional CMY centres, and the slide path's zone geometry.Fix
reference_print_density(0.75), holds the curve geometry on CPU and GPU, for prints and slides. No WGSL change.anchor_target_densityis read only where a metered anchor is placed:compute_pivotand Shadow Reach, through_anchor_linear_value. It inverts the midtone gamma, so the anchor prints exactly at the target.auto_sliders._density_shiftincludes the target term, so the shown and baked Density print the same as Auto Density.exposure_targetskey is unchanged, so no migration is necessary.THUMBNAIL_RENDER_VERSIONgoes from 15 to 16, because pixels change for installs with a retuned target. At the default target, no render changes.Behavior change
With Auto Density on and a retuned target, the target now moves only the exposure. The S-curve and zone centres stay at 0.75. Before, they moved with the target.
Known limit
With Cast Removal off on a crossover paper, a bake at a non-default target leaves R/B off by
(v_t − v*)·(1 − s_ch/s_g). One Density slider cannot hold a shift that depends on the slope of each channel. This is exact at the default target and with Cast Removal on.Tests
samples/06.raw: with Auto Density on, a target of 0.95 darkens the frame. With it off, the render is pixel-identical.