Repository navigation
feat(capture): show shutter speeds as the camera marks them - #1471
Merged
Merged
Conversation
Nikon publishes decimal seconds ("0.0333s" for 1/30), and the shutter
steppers, the meter's messages and the IR Shutter warning showed them
as published. They now show 1/30 below 0.3 s and 0.4" from there up.
The body's own spacing picks third- or half-stop speeds, because four
decimals cannot tell 1/800 from 1/750. A 1/N label stays as published,
and the camera's label is still the value a write sends.
The Metadata Preview printed the EXIF exposure rational unreduced
(10/300s from a D3300). It now reduces it (1/30s), in a form the export
writer parses back to the same time.
# Conflicts: # tests/test_scanlight_sidebar.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Shutter), the meter's messages and the IR Shutter warning show a
decimal label as a marked speed: Nikon's
0.0333sshows as1/30,0.4000sas0.4". A1/Nlabel stays as published, since bodiesdiffer (
1/2against0.5").store and what a write sends, so nothing written to the body changes.
spacing picks third- or half-stop speeds. An unknown spacing tries
third stops first.
shows (a D3300 stores 1/30 as
10/300). The text parses back to thesame time in the export writer.
Not covered
At the fast end, 1/3200 and 1/4000 both publish as
0.0003sand showas
1/3200. The Scanlight meter stops at 1/250.Tests
Formatter tests on full third- and half-stop decimal ladders, a stepper
test (shows fractions, stores and sends the camera label) and an EXIF
round-trip test.
make allpasses. Checked inmake run-simwith thesimulated camera given a Nikon-style decimal ladder.