fix: add IDA 8.5 compatibility - #3138
Open
1337Name wants to merge 2 commits into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
github-actions
Bot
dismissed
their stale review
August 5, 2026 01:50
CHANGELOG updated or no update needed, thanks! 😄
As seen in the link below IDA 8.5 uses the same updated api a IDA 9 as such the compat comparison is wrong and lead to a failure on loading the plugin because idaapi.get_inf_structure() has been removed in that idaapi. https://docs.hex-rays.com/8.5/developer-guide/idapython/idapython-porting-guide-ida-9
1337Name
force-pushed
the
fix/ida-8.5-compat
branch
from
August 5, 2026 02:03
c6ff4dc to
0ff1125
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just simple 1 line fix.
As seen in the link below IDA 8.5 uses the same (to my knowledge) updated api a IDA 9 as such the version comparison in capa/ida/helpers.py:59 mistakenly does not include ida 8.5 to the upgraded api. This lead to a failure on loading the plugin on ida 8.5 because idaapi.get_inf_structure() has been removed in that idaapi for both 8.5 and 9.x. but for ida 8.5 the path for the old api is taken.
The reason for this bug probably is that 8.5 was released after 9.0 so the helpers.py was never updated for the 8.5 release
Tested by loading the plugin with IDA 8.5.
REFERENCE
https://docs.hex-rays.com/8.5/developer-guide/idapython/idapython-porting-guide-ida-9#inf_structure-accessors
Checklist