Repository navigation
test(e2e): SSR is told apart by the home page's add-idea button, not the removed badge (ENG-909) - #3
Merged
Merged
Conversation
…the removed badge (ENG-909) The fork dropped the Powered by Fider footer (98a29e3), so the GoogleBot scenario failed on every run. The add-idea button is what the SSR unit test in react_test.go already uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-e2e-server failed on every run, because the GoogleBot scenario expects the Powered by Fider footer, which this fork removed in 98a29e3. Both SSR scenarios now check for the home page's add-idea button instead, the same marker react_test.go uses.