Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to both backend and frontend components, focusing on user experience, visual consistency, and share URL correctness. The backend now ensures share URLs are generated without redundant path components, and a corresponding test has been added. On the frontend, UI elements for session history and insights dialogs have been visually refined, and the insights toolbar now disables unavailable options with clearer messaging.
Backend: Share URL generation and testing
InsightService._build_share_urlto useurlsplit, ensuring that share URLs do not include extraneous path components from the configured base URL.test_share_url_strips_path_componentto verify that share URLs are correctly generated without the/insightspath.urlsplitfromurllib.parseto support the URL parsing logic.Frontend: UI/UX improvements
SessionHistorycomponent layout for better readability and alignment, updated color classes for improved accessibility, and adjusted button placement for consistency. [1] [2] [3] [4]InsightsReportDialogcomponent with updated styling, clearer sectioning, and improved button states for a more polished stakeholder report experience. [1] [2]Frontend: Insights toolbar usability
WINDOW_OPTIONSinInsightsToolbarto disable the "7 days" option, add descriptive messaging, and prevent user interaction with unavailable options. [1] [2]