Skip to content

fix: restore examples CI reliability - #125

Merged
dhruvja merged 4 commits into
mainfrom
dhruvja/fix/phase-02-examples
Sep 2, 2026
Merged

fix: restore examples CI reliability#125
dhruvja merged 4 commits into
mainfrom
dhruvja/fix/phase-02-examples

Conversation

@dhruvja

@dhruvja dhruvja commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Fix examples CI by correcting roll-dice formatting and lockfiles, updating eSPL to SDK 0.16.2, and documenting the optional submodule; validator funding remains covered by #123.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 48952ee7-f777-46e8-882e-db86539f653b

📥 Commits

Reviewing files that changed from the base of the PR and between c315770 and 0977096.

📒 Files selected for processing (1)
  • README.md

Walkthrough

The PR documents optional submodule setup, adds a funded validator account preload, updates the Ephemeral Rollups SDK version, and reformats roll-result code and tests without changing behavior.

Changes

Example maintenance

Layer / File(s) Summary
Funded validator account preload
scripts/test-locally.sh, scripts/fixtures/accounts/magicblock-validator-funded.json
The local test script validates and preloads a funded validator account fixture.
Ephemeral Rollups SDK version alignment
spl-tokens/anchor/app/package.json, spl-tokens/anchor/package.json
Both package manifests use @magicblock-labs/ephemeral-rollups-sdk version 0.16.2.
Roll-result formatting updates
roll-dice/anchor/app/lib/roll-result.ts, roll-dice/anchor/app/lib/roll-result.test.ts
The implementation and tests receive formatting-only changes. Existing behavior and assertions remain unchanged.
Optional submodule clone instructions
README.md
The README documents initialization of the optional private-payments submodule and notes that other examples do not require it.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: sporicle

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the pull request's primary goal of restoring CI reliability for the examples.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dhruvja/fix/phase-02-examples

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
binary-prediction-demo Ready Ready Preview Sep 2, 2026 12:20pm UTC
counter-session-keys Ready Ready Preview Sep 2, 2026 12:20pm UTC
er-rolldice Ready Ready Preview Sep 2, 2026 12:20pm UTC
magicblock-counter-example Ready Ready Preview Sep 2, 2026 12:20pm UTC
magicblock-engine-examples Ready Ready Preview Sep 2, 2026 12:20pm UTC
magicblock-rewards-dashboard Ready Ready Preview Sep 2, 2026 12:20pm UTC
rps-example Ready Ready Preview Sep 2, 2026 12:20pm UTC
spl-tokens Ready Ready Preview Sep 2, 2026 12:20pm UTC

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant