Repository navigation
Conversation
Splotch, Splatter, WaterResources, Pool, RiverSide and MossBoulder are now ChunkPlacers instead of Placers. Round patches use neighbor chunk seeds so they stay continuous across borders; pools, boulders and riversides are kept inside a single chunk. Chunk placers now get an rng seeded from the world seed and placer index, independent of earlier placers.
Spread is the block-above-the-ground counterpart of Splotch (used for mossy carpet and flowers), so it uses the same neighbor-seeded blobs.
Clumps use neighbor-seeded random walks so they stay continuous across chunk borders, and now follow the terrain surface instead of a single y level. Scatter picks random columns in the chunk. Bushes stay inside one chunk. PlantClumps was dead code and is removed.
The old placer picked a random y within +-4 of the anchor, so only 1 in 9 attempts landed on the surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splotch,Splatter,WaterResources,Pool,RiverSideandMossBoulderfromplacertochunk_placer, and updates all biome call sites tog.place_chunk(...).SplotchandWaterResourcespatches are seeded per source chunk, so they stay continuous across chunk borders.Pool,MossBoulderandRiverSideare kept inside one chunk.BiomeBuilder::generatenow gives each chunk placer an rng seeded from the world seed and the placer index (independent of earlier placers). This changes the random patterns of the existing chunk placers too.Behavior differences
WaterResourcesnow patches the floor of any water up to 10 deep (the old version only fired when the shifted column was lower than the anchor), soavg_per_chunkmay need retuning.placer_enabled!toggles no longer apply to these; they fall underBiomeChunkPlacers.LavaLake,PillarandMonumentare left as regular placers.Testing
cargo check --workspaceandcargo test -p rgen-placer -p rgen-biomepass. Not yet verified visually in a generated world.