Repository navigation
Conversation
Owner
|
Thanks, the cause is right: the desktop app's window-open handler denies the blank window printing opens, so Print silently did nothing there. The windowOpening change that allows only a named mailflow-print window from the app's own origin is the fix we want. Could you split this PR?
Once the fix is split out I'll test it on the desktop builds and merge it. |
dcoffin88
force-pushed
the
fix/message-page-print-button-electron
branch
from
October 28, 2026 22:03
737ab2f to
f4495d6
Compare
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes email printing in Electron.
Changes
Testing
Contributor License Agreement
By submitting this pull request I confirm that:
third-party material and confirmed it is compatible with the CLA).