Repository navigation
fix(compose): reply to sent message recipients - #692
Merged
maathimself merged 3 commits intoOct 28, 2026
Merged
maathimself merged 3 commits into
maathimself merged 3 commits into
Conversation
…ress A message from one of the account's own addresses replied to its external To or Cc, and otherwise to itself, ignoring Reply-To. A contact form that sends from and to the site's own address with the visitor in Reply-To then replied to the site instead of the visitor, which worked before. With no external To or Cc, the first external Reply-To address is now the reply target, before falling back to the account's own To or Cc. External To recipients still win over a team Reply-To on a sent copy.
Owner
|
Thanks, this fixes #691. One regression we found in review and fixed on your branch: when From is one of the account's own addresses and there are no external recipients, Reply-To was ignored, so a contact-form style message (From: me, To: me, Reply-To: visitor) replied to me instead of the visitor. Owned-sender replies now use an external Reply-To before falling back to self, with a test for that shape. Two follow-ups we noted but left out of this PR: Sent copies from "Send as" or delegated addresses still reply to the sender, and Forward from a threaded row still credits the oldest sender. |
# Conflicts: # frontend/src/utils/composeFromMessage.js
maathimself
approved these changes
Oct 28, 2026
maathimself
left a comment
maathimself
left a comment
Owner
There was a problem hiding this comment.
Approved: reviewed and tested, see the comment above.
Monkey7539
added a commit
to Monkey7539/mailflow
that referenced
this pull request
Oct 28, 2026
Brings in upstream 0441d23 (42 commits): 4.1.0, Reply with AI from a conversation and with an instruction (maathimself#577), replying to a sent message's recipients (maathimself#692), the conversation bar and cards drawn from the reading pane's buttons (maathimself#650), a moved message's new uid found without COPYUID, read-state and count fixes (maathimself#701), and the scheduled send follow-ups, among others. Conflicts: - ConversationPane.jsx: upstream rebuilt the conversation bar as icon buttons above the message list and removed ThreadBtn, so dev's old bar goes. Dev's two changes to it move into the new bar: no Snooze button without a snooze target, and the picker's Change snooze time action. - ComposeModal.render.test.js: both sides appended a describe block; upstream's first. Also: dev's conversation tests find the bar's buttons by aria-label instead of title, since Archive's title now carries its shortcut. Co-Authored-By: Claude Fable 5.1 <[email protected]>
maathimself
added a commit
that referenced
this pull request
Nov 1, 2026
…sender Replying to a message in Sent that went out from a "Send as" or delegated address MailFlow doesn't list as an alias went back to that address, not to the people it was sent to. A copy in the account's Sent folder (by its special-use flag, the folder mapping, or the usual names) now counts as the user's own, so Reply and Reply All answer its recipients, as they do for the account's address and its aliases. Forwarding a conversation row in the grouped list, from the context menu or with F, forwarded the row's newest message but credited it to the person who started the thread. The forward header now names the sender of the message being forwarded, as the reply quote already did. Follow-ups to #692.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replying to a sent message now addresses its original recipients instead of the sender. Reproduced on current main: send from
[email protected]to[email protected], open the Sent copy, and click Reply. Before this change, To contains the owner; afterwards, it contains the original recipient.Fix-sent-message-replies-addressing-the-sender.mp4
Changes
One commit based on current main. No migrations or new dependencies.
Testing
npm test -- --maxWorkers=2 --testTimeout=30000passes 3,939 tests (2 existing optional tests skipped), including the real PostgreSQL sender projection regression.npm testpasses all 4,073 tests.The demo uses fictional data and illustrates the behavior; it is not a live-provider test.
Closes #691
Refs #667
Contributor License Agreement
By submitting this pull request I confirm that: