Repository navigation
Conversation
dcoffin88
force-pushed
the
fix-richtoolbar-maintain-single-row
branch
2 times, most recently
from
October 25, 2026 22:07
40c7446 to
fc5d2a7
Compare
dcoffin88
force-pushed
the
fix-richtoolbar-maintain-single-row
branch
from
October 26, 2026 11:35
fc5d2a7 to
5284c77
Compare
maathimself
requested changes
Oct 30, 2026
maathimself
left a comment
Owner
There was a problem hiding this comment.
I tested this merged with current main, in Chromium, Firefox and WebKit. In main's default 540 px composer with AI on and a signature, AI and </> wrap to a second row; with this PR the toolbar stays on one row at 100% and 130% font size, and the + menu, AI Assist and </> all work. The + approach is fine. Two things before it can merge:
- #577's tests. Merged with current main, 13 tests in
ComposeModal.render.test.jsfail: the Reply with AI and Write draft tests press the AI button directly, and it is now behind +. They need the same "press More first" step you added toaiApplyandaiLength. Please merge main into the branch so CI runs them. - The table picker on a phone. This adds the table button to the phone toolbar, and
openTablekeeps the picker on screen by assuming it is 200 px wide. It is wider than that, so on a 360 px phone at 130% font size the 4×4 option runs off the right edge. Please clamp it with its real width, for example by measuring the picker once it renders, or by right-aligning it to the button when it would overflow.
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores a compact, single-row compose toolbar by moving additional controls into an expandable More (+) menu, matching the existing mobile menu behavior.
Changes
Testing
Tested on my dev environment.
Contributor License Agreement
By submitting this pull request I confirm that:
third-party material and confirmed it is compatible with the CLA).