Repository navigation
feat(i18n): start each session in the language its SSH client sends - #121
Merged
Merged
Conversation
OpenSSH sends LANG and LC_* by default, so a session now follows LC_ALL, LC_MESSAGES or LANG when it names English or Chinese, and the server's language otherwise. The suites unset those variables so a developer's locale no longer changes what they see.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs your call:
TNT_LANGfor that session. A Chinese-speaking user whose Mac is set to en_US sees English, as they would withoutTNT_LANG(src/bootstrap.c).Everyone saw the server's language until they typed
:lang, although OpenSSH already sends the client's locale.LC_ALL,LC_MESSAGESandLANGfrom the SSH channel's env requests, in that order of precedence, without exporting them. English or Chinese starts the session in that language; anything else keeps the server's.tnt.8andtnt-chat.7describe it;test_client_lang.shcovers Chinese, precedence, English, an unknown locale and none.run_suites.shunsets those variables so the suites don't follow the developer's locale.