Repository navigation
feat(module): tell the identity module about sign-ins TNT makes itself - #118
Merged
Merged
Conversation
The identity:write module now receives three notifications, so it can report every identity change to m1ngsama ID (#117): - identity.recognized when a bound SSH key signs an interactive session in at connect. Exec requests recognised by key send nothing. - identity.key_bound when identity.verified binds a key that was not bound to that handle, with previous_handle when the key moved. - identity.signed_out on :logout, with forgot_key and the fingerprint when a key was unbound. Like presence records they open no response window and are dropped when the module's queue is full; the drop count on standard error now reads "dropped N notifications".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs your call:
dropped N notificationsinstead ofdropped N presence events, since the new records share that queue (src/module_runtime.c).Recognition by a bound SSH key, binding a key and
:logouthappen inside TNT, so m1ngsama ID's activity log could not record them. Refs #117.identity:writemodule now receivesidentity.recognizedwhen a session signs in by its bound key,identity.key_boundwhen:loginbinds a new key (withprevious_handlewhen it moves from another handle), andidentity.signed_outon:logout(withforgot_keyand the fingerprint). Exec sessions recognised by key send nothing.make testpasses, with 35 identity checks.