Repository navigation
feat: deliver tool replies, notices and actions through the gateway - #107
Merged
Merged
Conversation
Modules now receive message.created for replies other modules publish, for join, leave and rename notices, and a message.post whose text starts with "/me " is published as an action. A module still never receives its own messages. This lets the WebSocket gateway show tool replies and room notices that only SSH users could see.
…mentions Message frames now carry kind (text, action, system, module) and the handles mentioned in the text; actions arrive with the actor as sender, module replies with the module name. Notices and module replies are no longer dropped from history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Web users could trigger the room tools (/roll, /flip, /8ball, /choose, /quote) but never saw the replies, and never saw join, leave or rename notices: module replies and notices were not delivered to modules, and the gateway dropped them from history.
Modules now receive message.created for replies other modules publish and for join, leave and rename notices; a message.post whose text starts with "/me " is published as an action. A module still never receives its own messages. The gateway classifies every message as text, action, system or module (actions carry the actor as sender, module replies the module name), lists the handles mentioned in the text, and keeps notices and module replies in history.
Verified: module runtime and privileged module tests (20 and 14 pass), gateway
bun test(52 pass) andtsc; built from this branch on chat.m1ng.space and deployed together with the gateway (previous binaries kept in /root).