Repository navigation
feat(gateway): make sends idempotent with a client nonce - #106
Merged
Merged
Conversation
A send may carry a nonce; a resend with the same nonce from the same handle within ten minutes is answered with the original message instead of being posted again, so a client retrying after a dropped socket cannot duplicate a message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Universe marks a message as failed when the socket drops before the echo arrives; retrying it posted a second copy (m1ngsama/universe#16).
A
sendframe may carry anonce(up to 64 characters). The gateway remembers(handle, nonce)for ten minutes; a resend with the same pair is answered with the original message frame instead of being posted again. Message frames carry the nonce back so the client can settle the right local bubble. Sends without a nonce behave as before.Verified:
bun test(50 pass),bunx tsc --noEmit; deployed to chat.m1ng.space (previous binary kept in /root).