Skip to content

[Audit FS-03 / later audit] Text merge follows an unsafe selected backup path #83

Open

Description

@lumenpearson

Source and evidence status

https://github.com/lumenpearson/cdpiui/blob/ee4771675956fe213634675f37579362efb7e0eb/docs/AUDIT-STATUS.ru.md

Classification: confirmed later-audit finding; implementation in unmerged PR10. Source severity: Not assigned in the continuation journal; assess current impact during triage.. This is the historical source rating, not a new current severity assessment. Affected source revision: d72ad478bc05c6ab9e53f46da1a2b6c58690b202.

Source aliases: None recorded.

Problem, cause and impact

Text merge follows an unsafe selected backup path. Mutable names or incomplete transaction ownership cross the stated boundary.

Expected safe behavior: Reject unsafe inputs before side effects; preserve owned originals and outside marker bytes; report retained recovery paths.

Where it was found

  • ZipService.MergeTextFileAsync

Original paths and line numbers describe the audited source. Refactoring can move the current implementation.

Reproduction

Status: Proposed acceptance procedure; the continuation journal separately records historical RED/GREEN and native results. No new product PoC was run in process setup.

Environment: Disposable scratch trees and isolated Windows fixtures. Do not target installed Store data or system settings.

  1. Use an ordinary source with a backup name that is a scratch symlink or hard link to an outside marker. Verify refusal and unchanged outside bytes.

The original audit was static. Its check marks do not establish an executed PoC. Process setup does not claim a new runtime reproduction.

Existing fix and remaining work

PR10 checks the selected backup and uses native no-follow write/append operations. Parent and hard-link races belong to the same acceptance boundary.

Not in baseline main. PR10 is draft at the recorded HEAD; integration and scoped acceptance remain open.

Code and regression evidence

Acceptance criteria

  • Reconcile the historical claim with the current source and record a confirmed, disproved, duplicate or residual-risk disposition.
  • Execute an appropriate bounded regression or explain why a source-only check is sufficient for this issue.
  • For a fix, record the integrated commit, exact-head CI and independent review.
  • Record native or installed-product evidence when the affected boundary requires it.
  • Preserve remaining risk, dependencies and release acceptance as separate open work.

Ownership and delivery data

Triage owner: lumenpearson. Milestone G1. Priority P1; Area Security; Risk High; planned Status Verification. Dates and estimates remain unset until triage. Implementation ownership must be agreed before work starts.

Related work

Security index #21; full audit #12; PR10 acceptance #13; installed-product acceptance #16; delivery contract #11. Duplicate source references must point to this finding rather than create another issue.

Current task contract adoption

The original record above is retained unchanged. The sections below complete its current delivery contract under #205. Existing criteria remain outstanding unless their original evidence already marks them complete.

Context and expected result

This issue owns the current acceptance of [Audit FS-03 / later audit] Text merge follows an unsafe selected backup path.

Text merge follows an unsafe selected backup path. Mutable names or incomplete transaction ownership cross the stated boundary.

Expected safe behavior: Reject unsafe inputs before side effects; preserve owned originals and outside marker bytes; report retained recovery paths.

The original source identity and evidence classification remain authoritative:

https://github.com/lumenpearson/cdpiui/blob/ee4771675956fe213634675f37579362efb7e0eb/docs/AUDIT-STATUS.ru.md

Classification: confirmed later-audit finding; implementation in unmerged PR10. Source severity: Not assigned in the continuation journal; assess current impact during triage.. This is the historical source rating, not a new current severity assessment. Affected source revision: d72ad478bc05c6ab9e53f46da1a2b6c58690b202.

Source aliases: None recorded.

Scope and boundaries

The named issue retains its original product and verification boundary. Complete only the remaining work recorded for this case:

PR10 checks the selected backup and uses native no-follow write/append operations. Parent and hard-link races belong to the same acceptance boundary.

Not in baseline main. PR10 is draft at the recorded HEAD; integration and scoped acceptance remain open.

The policy migration does not declare an implementation, integrated branch, installed-product scenario or release gate complete. Related work keeps its own acceptance.

Verification plan

Use the existing case-specific procedure and evidence boundary below. A proposed procedure remains unexecuted until a new result records its exact revision and environment.

Status: Proposed acceptance procedure; the continuation journal separately records historical RED/GREEN and native results. No new product PoC was run in process setup.

Environment: Disposable scratch trees and isolated Windows fixtures. Do not target installed Store data or system settings.

  1. Use an ordinary source with a backup name that is a scratch symlink or hard link to an outside marker. Verify refusal and unchanged outside bytes.

The original audit was static. Its check marks do not establish an executed PoC. Process setup does not claim a new runtime reproduction.

Record commands, actual results, full tested SHA, independent review and required exact-head CI. Perform the native or installed-product check when this boundary requires it. A source-only method needs a case-specific sufficiency explanation. Do not infer execution from test-source presence.

Risk and recovery

Actual triage classification is Priority P1, Area Security, Risk High. This is distinct from a historical audit or tool severity.

The affected mechanism is:

Text merge follows an unsafe selected backup path. Mutable names or incomplete transaction ownership cross the stated boundary.

Expected safe behavior: Reject unsafe inputs before side effects; preserve owned originals and outside marker bytes; report retained recovery paths.

Before changing this boundary, record a bounded recovery method for the affected state. Preserve working inputs and previous evidence. Revert an unaccepted correction or restore only owned fixture state when its checks fail. Product recovery and destructive actions remain subject to their existing authorization and acceptance. No recovery test is invented by this migration.

Dependencies and documentation

Security index #21; full audit #12; PR10 acceptance #13; installed-product acceptance #16; delivery contract #11. Duplicate source references must point to this finding rather than create another issue.

Existing source and regression documentation:

Task lifecycle: policy #203, PR #204, rollout #205, and the acceptance procedure.

Project classification

Type: type:audit
Area: Security
Priority: P1
Risk: High
Gate: G1
Owner: @lumenpearson
Project: CDPI UI — Delivery & Release Gates

Progress and evidence

Current API state is open. Actual Project status is Verification, as read from the current browser export. The original description and case evidence remain intact. The rollout adds a task contract; it does not run a product regression, accept a fix, change source or close this issue.

@lumenpearson remains the assigned maintainer and triage contact. Individual implementation ownership and a branch must be recorded before new source work starts. Historical fixes and tests retain their original revisions. No due date or estimate is fabricated.

Activity

  1. self-assigned this
    on Nov 10, 2026
  2. added
    type:auditInvestigate a risk. A new defect is not yet confirmed.
    area:securityTrusted paths, privileges, pipe trust, signatures and protected operations.
    on Nov 10, 2026
  3. moved this from Review to Verification in CDPI UI — Delivery & Release Gateson Nov 10, 2026
  4. lumenpearson commented on Nov 10, 2026

    @lumenpearson
    OwnerAuthor
    -readback

    Current task policy applied

    The original case record remains intact. Added sections: Context and expected result, Scope and boundaries, Verification plan, Risk and recovery, Dependencies and documentation, Project classification, Progress and evidence.

    This issue now has the complete active-task contract required by policy #203 / PR #204. The named issue retains its original product and verification boundary. Complete only the remaining work recorded for this case:

    Actual Project 7 baseline: Verification; P1; Security; High; G1; @lumenpearson. The migration preserves this working state, labels, assignee and milestone. It does not certify semantic acceptance, run a product test or close the issue.

    After this issue's own criteria pass, the execution owner must post the tested revision, commands, environment, review and limits, close as completed, set Done immediately, and read back both states. Local completion cannot close a broader integration or release gate.

    See rollout #205 for branch ownership, preservation checks and the fresh Project export.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:securityTrusted paths, privileges, pipe trust, signatures and protected operations.type:auditInvestigate a risk. A new defect is not yet confirmed.

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions