Skip to content

[Retrospective] Preserve UI event behavior and expose asynchronous failures #136

Closed

Description

@lumenpearson

Completed result

Await GUI operations and marshal changed service events to UI queues; detach subscriptions and reject duplicate async-command execution; correct initial toggle timing, saved-preset selection and command error propagation after MVVM conversion

Scope and completion boundary

Retrospective completed implementation in historical main through merged PR9; current security/native/release acceptance remains separate.

Acceptance record

  • Await GUI operations and marshal changed service events to UI queues.
  • detach subscriptions and reject duplicate async-command execution.
  • correct initial toggle timing, saved-preset selection and command error propagation after MVVM conversion.

Evidence and documentation

  1. freshly_inspected_integrated_commit — 204804423a566874272e310a15d26085110e7bbf. Source: Git commit record.
  2. freshly_inspected_integrated_commit — c0abbf0c8929e3e10a3e40796d908e76c7f7287b. Source: Git commit record.
  3. freshly_inspected_integrated_commit — 3601fa7499fef0af6e557e2966391f283632f679. Source: Git commit record.
  4. freshly_inspected_integrated_commit — d5a5421159bb9fedcd21e728e1d59ce675a04968. Source: Git commit record.
  5. freshly_inspected_integrated_commit — be59cd31701575c6b8f02a156e1c48497de5ce33. Source: Git commit record.
  6. freshly_inspected_integrated_commit — 3ab43d5234c14c2a479929ad6316bf6949bb88f0. Source: Git commit record.
  7. freshly_inspected_integrated_commit — ce08861b0d286fea7de557066d9683b64a4d21c6. Source: Git commit record.
  8. freshly_inspected_owning_source — 7ead95f7756057f67cd113671a7f84cf422e8d32. Source: CDPIUI/ViewModels/AsyncRelayCommand.cs.
  9. freshly_inspected_owning_source — 7ead95f7756057f67cd113671a7f84cf422e8d32. Source: CDPIUI/Controls/CreateConfigHelper/ComponentSettingUserControl.xaml.cs.
  10. freshly_inspected_owning_source — 7ead95f7756057f67cd113671a7f84cf422e8d32. Source: CDPIUI/Controls/MainPage/ComponentTileUserControl.xaml.cs.
  11. recorded_historical_verification — 620b8dfc3391e372368af0cce24838df3986e457. Source: https://github.com/lumenpearson/cdpiui/pull/2.
  12. recorded_historical_verification — 651075d0a86a6e856ba780e65ec684b3d47b9479. Source: https://github.com/lumenpearson/cdpiui/pull/4.
  13. recorded_historical_verification — fa0079d. Source: https://github.com/lumenpearson/cdpiui/pull/6.

The verification comment below preserves the case-specific results, methods, and limitations. Historical execution results remain attached to their recorded revisions.

Remaining boundaries

  • Completion means the bounded historical implementation milestone; linked security, native, integration and release acceptance remains separate.
  • No test, build or native scenario was rerun in this read-only retrospective.
  • Native initialization/theme/close timing remains integrated acceptance. Historical PR6 independent source comparisons found and fixed the three documented conversion regressions.

Project classification and ownership

Delivery Project 7; target Status Done; Priority P2; Area Reliability; Risk Medium; gate G1.
Maintainer and retrospective record owner: @lumenpearson. No invented due date or estimate is assigned.

Related work

#11, #14, #16, #70. PR #2, PR #4, PR #6

Closing this scoped record does not close a related audit finding, integrated acceptance issue, milestone, or release gate. Those retain their own criteria.

Activity

  1. self-assigned this
    on Nov 10, 2026
  2. added
    type:bugFix a reproducible defect in application behavior.
    area:reliabilityCancellation, errors, races, data preservation and recovery.
    on Nov 10, 2026
  3. lumenpearson commented on Nov 10, 2026

    @lumenpearson
    OwnerAuthor
    -verification

    Case-specific verification and close-out

    The retrospective reconciles the source evidence with this bounded completion claim. It does not replay historical tests or native actions unless explicitly stated below.

    1. freshly_inspected_integrated_commit

    Revision: 204804423a566874272e310a15d26085110e7bbf.
    Source record: Git commit record.

    Await GUI operations and expose previously hidden errors. Verified ancestor of historical main. Original-Commit: dac64a1

    2. freshly_inspected_integrated_commit

    Revision: c0abbf0c8929e3e10a3e40796d908e76c7f7287b.
    Source record: Git commit record.

    Dispatch component and GoodCheck events to the UI thread. Verified ancestor of historical main. Original-Commit: a24da24

    3. freshly_inspected_integrated_commit

    Revision: 3601fa7499fef0af6e557e2966391f283632f679.
    Source record: Git commit record.

    Detach singleton service handlers when pages unload. Verified ancestor of historical main. Original-Commit: d6d0cbe

    4. freshly_inspected_integrated_commit

    Revision: d5a5421159bb9fedcd21e728e1d59ce675a04968.
    Source record: Git commit record.

    Forward asynchronous command failures to the application handler. Verified ancestor of historical main. Original-Commit: fa0079d

    5. freshly_inspected_integrated_commit

    Revision: be59cd31701575c6b8f02a156e1c48497de5ce33.
    Source record: Git commit record.

    Suppress setting toggle commands until the control has loaded. Verified ancestor of historical main. Original-Commit: aec2877

    6. freshly_inspected_integrated_commit

    Revision: 3ab43d5234c14c2a479929ad6316bf6949bb88f0.
    Source record: Git commit record.

    Apply the saved tile preset after the configuration list is filled. Verified ancestor of historical main. Original-Commit: a992fd7

    7. freshly_inspected_integrated_commit

    Revision: ce08861b0d286fea7de557066d9683b64a4d21c6.
    Source record: Git commit record.

    Correct MVVM toggle, selection, save, and download event handling. Verified ancestor of historical main. Original-Commit: 8f10696

    8. freshly_inspected_owning_source

    Revision: 7ead95f7756057f67cd113671a7f84cf422e8d32.
    Source record: CDPIUI/ViewModels/AsyncRelayCommand.cs.

    Inspected integrated historical-main source: 61 lines; methods include CanExecute, Execute, ExecuteAsync, NotifyCanExecuteChanged. Static implementation/document inspection, not a fresh native result.

    9. freshly_inspected_owning_source

    Revision: 7ead95f7756057f67cd113671a7f84cf422e8d32.
    Source record: CDPIUI/Controls/CreateConfigHelper/ComponentSettingUserControl.xaml.cs.

    Inspected integrated historical-main source: 323 lines; methods include ApplyCheckedState, NotifyValueChanged, NotifyToggled, ToggleChecked, MainCheckBox_Checked, MainCheckBox_Unchecked, MainToggleSwitch_Toggled, TextBox_TextChanged, EnumPropertyComboBox_SelectionChanged, SelectFileButton_Click, ViewSelectedFileButton_Click. Static implementation/document inspection, not a fresh native result.

    10. freshly_inspected_owning_source

    Revision: 7ead95f7756057f67cd113671a7f84cf422e8d32.
    Source record: CDPIUI/Controls/MainPage/ComponentTileUserControl.xaml.cs.

    Inspected integrated historical-main source: 166 lines; methods include CheckVisualState, ShowOutputWindowAsync, ShowComponentSettingsAsync, StatusBrush, AccentBrush, ComponentTileUserControl_SizeChanged, ComponentTileUserControl_Unloaded, ConfigChooseCombobox_SelectionChanged, ConfigSettingToggleSwitch_Toggled, AvailableFeaturesButton_Click. Static implementation/document inspection, not a fresh native result.

    11. recorded_historical_verification

    Revision: 620b8dfc3391e372368af0cce24838df3986e457.
    Source record: https://github.com/lumenpearson/cdpiui/pull/2.

    Live PR body read2026-11-10; historical results, not rerun here: 192 tests; CI libraries, GUI, utility and installer builds. Live GUI/tray use unverified.

    12. recorded_historical_verification

    Revision: 651075d0a86a6e856ba780e65ec684b3d47b9479.
    Source record: https://github.com/lumenpearson/cdpiui/pull/4.

    Live PR body read2026-11-10; historical results, not rerun here: 559 tests; strict restore and Windows CI library/GUI/tools/layout/MSI; single-file utilities. Native usage pending.

    13. recorded_historical_verification

    Revision: fa0079d.
    Source record: https://github.com/lumenpearson/cdpiui/pull/6.

    Live PR body read2026-11-10; historical results, not rerun here: 590 tests; independent six-area behavior comparisons and Binding-path inspection; Windows CI XAML/build/layout/MSI/tools. Live pages not accepted.

    Acceptance limits retained

    • Completion means the bounded historical implementation milestone; linked security, native, integration and release acceptance remains separate.
    • No test, build or native scenario was rerun in this read-only retrospective.
    • Native initialization/theme/close timing remains integrated acceptance. Historical PR6 independent source comparisons found and fixed the three documented conversion regressions.

    The named result is complete within the issue scope. The acceptance record supports closure as completed. Related integration, installed-product, security and release work remains governed by its own issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:reliabilityCancellation, errors, races, data preservation and recovery.type:bugFix a reproducible defect in application behavior.

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions