docs(targets): document the login-button disable target - #27
Draft
Ludovic-Iafrate wants to merge 1 commit into
Draft
docs(targets): document the login-button disable target#27Ludovic-Iafrate wants to merge 1 commit into
Ludovic-Iafrate wants to merge 1 commit into
Conversation
The top bar's sign-in entry point for anonymous users can be disabled
via window.lumapps.disable('login-button'), same as favorites,
bookmarks, and the contribution button. It never affects the
avatar/profile menu shown to a connected user — that element cannot
be disabled.
Renamed from user-avatar following review feedback: the target only
ever affects the anonymous login link, not an actual avatar.
Ludovic-Iafrate
force-pushed
the
docs/user-avatar-disable-target
branch
from
August 13, 2026 00:08
6fad235 to
8b8d6e6
Compare
Ludovic-Iafrate
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
login-buttondisable target:window.lumapps.disable('login-button')hides the top bar's sign-in entry point for anonymous users, the same wayfavorites,bookmarks, andcontribution-buttonalready work.capabilities.md.api.md.Renamed from
user-avatarfollowing review feedback on thelumapps-webPR:UserProfileDropdownrenders a login link for unconnected users and the real avatar/menu only once connected, so the target was never actually "the avatar".Do not merge before the corresponding
lumapps-webchange is live in production. This documents a capability that does not exist yet at runtime — merging early would advertise a feature customers can't actually use.Tracking PR: lumapps/lumapps-web#17348
Testing
No manual testing required — documentation-only change.