Repository navigation
Harmonize dotfiles profiles and tooling - #16
Conversation
Co-authored-by: Luke D Williams <[email protected]>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9fa71dbf5b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| local dotfiles_dir="${DOTFILES_DIR:-$HOME/dotfiles}" | ||
| local management_script="$dotfiles_dir/common/.bashrc.d/dotfiles_management.bash" | ||
| local update_command | ||
| printf -v update_command 'source %q && update-dotfiles' "$management_script" |
There was a problem hiding this comment.
When DOTFILES_DIR is set as an ordinary shell variable rather than exported, the notification correctly builds a command that sources the management script from the custom clone, but the newly launched bash -c does not inherit that variable. Consequently, update-dotfiles calls _dotfiles_dir, falls back to ~/dotfiles, and either updates the wrong clone or reports it missing. Include the resolved directory in the launched command's environment rather than preserving only the script path.
Useful? React with 👍 / 👎.
2 participants
Summary
--updatea dedicated tool/Flatpak-only path that skips Stow and service setupDOTFILES_DIRconsistently across update, notification, profile, and secret toolingValidation
commonwithpersonal,work,steamos, andmac, plus therootpackageDOTFILES_DIRresolution passes, including a path containing spacesShellCheckis not installed in the environment; Bash parser checks passed.