Create a new piezo endpoint for updating data - #136
Conversation
ifndefJOSH
left a comment
ifndefJOSH
left a comment
There was a problem hiding this comment.
I just have a couple of questions about whether or not there's any potentially sensitive information about jobs in error messages that could leak out?
| val errorMsg = "Exception caught updating the job data map of job %s %s. -- %s".format( | ||
| jobKey.getGroup, | ||
| jobKey.getName, | ||
| e.getLocalizedMessage(), |
There was a problem hiding this comment.
Is this exception passed through to the HTTP response? If so we need to verify nothing sensitive is exposed.
| "updated" -> updated.map(jobKeyJson), | ||
| "failures" -> failures, | ||
| ) | ||
| if (failures.isEmpty) Ok(body) else MultiStatus(body) |
There was a problem hiding this comment.
I'm curious who will be calling this endpoint? Other services or will it be public? If the latter, failures need to be sanitized to ensure no sensitive data leaks out.
| GET /data/jobs com.lucidchart.piezo.admin.controllers.Jobs.getJobsDetail | ||
| GET /data/jobs/:group/:name com.lucidchart.piezo.admin.controllers.Jobs.getJobDetail(group: String, name: String) | ||
|
|
||
| POST /data/jobs/job-data-map com.lucidchart.piezo.admin.controllers.Jobs.patchJobDataMaps |
There was a problem hiding this comment.
Curious why this is a POST vs a PATCH request which the controller method implies.
|
Could an in progress job persist its job data after this endpoint updates the |
3 participants
Create a new piezo endpoint that allows us to update job data for multiple jobs at once