Skip to content

🔒 Fix potential DOM-based XSS in App Stack Auditor #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lsb11 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🔒 Fix potential DOM-based XSS in App Stack Auditor #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 35 additions & 8 deletions src/pages/shopify-app-stack-kill-or-keep-auditor.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,18 +389,45 @@ const tocHeadings = [
document.getElementById('app-free').textContent = '£' + freeTotal.toLocaleString() + '/mo';
document.getElementById('app-annual').textContent = '£' + (freeTotal * 12).toLocaleString() + '/yr';

let killHTML = '';
const killListContainer = document.getElementById('app-kill-list');
killListContainer.textContent = '';

if (killItems.length) {
killHTML = '<div style="font-size:10px;letter-spacing:.15em;text-transform:uppercase;color:#6b7671;margin-bottom:12px;">YOUR_KILL_LIST</div>';
const header = document.createElement('div');
header.setAttribute('style', 'font-size:10px;letter-spacing:.15em;text-transform:uppercase;color:#6b7671;margin-bottom:12px;');
header.textContent = 'YOUR_KILL_LIST';
killListContainer.appendChild(header);

killItems.forEach(item => {
killHTML += '<div style="display:flex;align-items:center;justify-content:space-between;padding:10px 14px;border:1px solid rgba(52,211,119,.2);background:rgba(52,211,119,.04);margin-bottom:6px;gap:12px;">';
killHTML += '<div><div style="font-size:11px;font-weight:700;color:#fff;">' + item.name.split('(')[0].trim() + '</div>';
killHTML += '<div style="font-size:10px;color:#6b7671;">Replace with: ' + item.replace + '</div></div>';
if (item.link) killHTML += '<a href="' + item.link + '" style="font-size:10px;font-weight:700;letter-spacing:.08em;color:#34d377;text-decoration:none;white-space:nowrap;border:1px solid rgba(52,211,119,.3);padding:6px 12px;">SET UP FREE →</a>';
killHTML += '</div>';
const itemContainer = document.createElement('div');
itemContainer.setAttribute('style', 'display:flex;align-items:center;justify-content:space-between;padding:10px 14px;border:1px solid rgba(52,211,119,.2);background:rgba(52,211,119,.04);margin-bottom:6px;gap:12px;');

const textWrapper = document.createElement('div');

const titleDiv = document.createElement('div');
titleDiv.setAttribute('style', 'font-size:11px;font-weight:700;color:#fff;');
titleDiv.textContent = item.name.split('(')[0].trim();

const replaceDiv = document.createElement('div');
replaceDiv.setAttribute('style', 'font-size:10px;color:#6b7671;');
replaceDiv.textContent = 'Replace with: ' + item.replace;

textWrapper.appendChild(titleDiv);
textWrapper.appendChild(replaceDiv);
itemContainer.appendChild(textWrapper);

if (item.link) {
const linkEl = document.createElement('a');
linkEl.setAttribute('href', item.link);
linkEl.setAttribute('style', 'font-size:10px;font-weight:700;letter-spacing:.08em;color:#34d377;text-decoration:none;white-space:nowrap;border:1px solid rgba(52,211,119,.3);padding:6px 12px;');
linkEl.textContent = 'SET UP FREE →';
itemContainer.appendChild(linkEl);
}

killListContainer.appendChild(itemContainer);
});
}
document.getElementById('app-kill-list').innerHTML = killHTML;

document.getElementById('app-result').classList.add('show');
}

Expand Down