Skip to content

[doc] Update stages doc with top-level stages#597

Merged
marnovandermaas merged 1 commit into
lowRISC:mainfrom
martin-velay:top_level_stages
Jul 24, 2026
Merged

[doc] Update stages doc with top-level stages#597
marnovandermaas merged 1 commit into
lowRISC:mainfrom
martin-velay:top_level_stages

Conversation

@martin-velay

Copy link
Copy Markdown
Contributor

No description provided.

@martin-velay

Copy link
Copy Markdown
Contributor Author

@marnovandermaas, WDYT?

@marnovandermaas marnovandermaas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this PR. I really enjoyed the motivation sections you added. I put some of my thoughts in here, which I hope are useful.

Comment thread doc/proj/stages.md Outdated
Comment thread doc/proj/stages.md Outdated
Comment thread doc/proj/stages.md Outdated
Comment thread doc/proj/stages.md
Comment thread doc/proj/stages.md Outdated
Comment thread doc/proj/stages.md Outdated
Comment thread doc/proj/stages.md Outdated
Comment thread doc/proj/stages.md Outdated
Comment thread doc/proj/stages.md
Comment thread doc/proj/stages.md Outdated
@martin-velay
martin-velay marked this pull request as ready for review June 12, 2026 15:42
@martin-velay
martin-velay force-pushed the top_level_stages branch 3 times, most recently from 3a5f103 to 274ac44 Compare June 15, 2026 11:46
@martin-velay

Copy link
Copy Markdown
Contributor Author

@marnovandermaas,

  • I have rebased on the main in the 1st push.
  • The 2nd and 3rd push address some comments. Let me know if you are happy with it? In that case could you mark the related comments as resolved?

@martin-velay
martin-velay force-pushed the top_level_stages branch 3 times, most recently from 548a6df to 81cf5ee Compare July 15, 2026 06:53

@marnovandermaas marnovandermaas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another few comments from my end. The main issue I still have is the VPLAN and TESTPLAN completed statements for V1 and that these are not revisited in V2 and V3.

Comment thread doc/proj/stages.md Outdated
Comment thread doc/proj/stages.md Outdated
Comment thread doc/proj/stages.md Outdated
Comment thread doc/proj/stages.md Outdated
Comment thread doc/proj/stages.md Outdated
Comment thread doc/proj/stages.md Outdated
Comment thread doc/proj/stages.md
Comment thread doc/proj/stages.md
Comment thread doc/proj/stages.md Outdated
@martin-velay

Copy link
Copy Markdown
Contributor Author

@marnovandermaas, I think I have addressed most of your comments. I hope you'll be satisfied. At least you've raised valid points again. Thanks!

@marnovandermaas marnovandermaas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes. I am happy for these changes to go in now.

@marnovandermaas
marnovandermaas added this pull request to the merge queue Jul 24, 2026
Merged via the queue into lowRISC:main with commit beb0f76 Jul 24, 2026
6 checks passed
@martin-velay
martin-velay deleted the top_level_stages branch July 24, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants