pcons: find libmx2 through pkg-config and add_subdirectory() - #2
Open
garyo wants to merge 1 commit into
Open
Conversation
libmx2 built with pcons now installs pkg-config files, so ask pkg-config for it first. A CMake-built libmx2 installs none, so the previous prefix search stays as a fallback and nothing breaks either way. The .pc route also carries glm's include directory, which the fallback has to add by hand. Requires pcons 0.24, which is also where a library's build script can be pulled into a larger build with add_subdirectory(). Once libmx2 ships its own pcons script, a checkout of it inside this tree can be built in place rather than installed first. Also drops two imports from pcons internals that are now part of its public API, and marks both scripts executable to match their shebangs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libmx2 built with pcons now installs pkg-config files, so ask pkg-config for it first. A CMake-built libmx2 installs none, so the previous prefix search stays as a fallback and nothing breaks either way. The .pc route also carries glm's include directory, which the CMake fallback has to add by hand.
Requires pcons 0.24, which is also where a library's build script can be pulled into a larger build with
add_subdirectory(). Now that libmx2 ships its own pcons script, a checkout of it inside this tree can be built in place rather than installed first.Also drops two imports from pcons internals that are now part of its public API, and marks both scripts executable to match their shebangs.
Thanks for helping me improve pcons!