Repository navigation
docs(release): record v2.4.0 baseline, Feishu guide link, and DSH publish workflow fix - #9224
Conversation
Signed-off-by: LoopX Agent <[email protected]>
…ng plugin tags Signed-off-by: LoopX Agent <[email protected]>
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent · Gemini · Google · self_reported
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
This exact-head review of PR #9224 (9224@90c3fb2cfca8094a41eff9465442b3771a238101) approves the post-release v2.4.0 documentation synchronization and the .github/workflows/dsh-plugin-publish.yml artifact-path and main-dispatch repair.
动机 / Motivation
Operators upgrading to LoopX 2.4.0 or publishing existing DSH plugin releases from GitHub Actions hit two post-release documentation and automation gaps after v2.4.0 shipped at a6ffb3be6e7bdb48e02311ec58d618200fe0501c.
Before this change, docs/product/releases/v2.4.0.md and docs/product/release-readiness.md lacked links to the verified v2.4.0 release record and illustrated Feishu upgrade guide (https://my.feishu.cn/docx/JXvbdWcFDoZJgvxktvScYfJwnRf), and .github/workflows/dsh-plugin-publish.yml exported DSH_ARTIFACT=output/... without a leading ./ (causing npm v11 on Node 24 to treat output/dsh-loopx-plugin-0.1.1-beta.7.tgz as GitHub shorthand ssh://[email protected]/output/... and fail run 44954216246 with exit 128) while blocking workflow_dispatch from main so a fixed workflow on main could not republish an earlier immutable plugin tag; after this change, the bilingual release note and release-readiness timeline cite the verified v2.4.0 artifacts and personal Feishu guide, and the publish workflow prefixes ./output/ while permitting main dispatches whose checkout remains pinned to refs/tags/<release_tag>.
Observably, independent checks confirm v2.4.0 and origin/stable resolve to a6ffb3be6e7bdb48e02311ec58d618200fe0501c, PyPI loopx==2.4.0 and all listed release assets are live, the personal Feishu guide (JXvbdWcFDoZJgvxktvScYfJwnRf) is publicly readable (anyone_readable) with 3 public-safe 2.4.0 interface screenshots, npm's package argument parser resolves ./output/... as a local file tarball instead of github: git shorthand, and the added workflow test plus full DSH plugin validation pass.
This PR covers only post-release v2.4.0 docs links, the DSH npm publish workflow fix, its README clarification, and its workflow structural test; it does not modify origin/stable, rebuild plugin/Core binaries, or grant npm registry ownership/Trusted Publisher setup.
- Specification basis: Evaluated against the pre-PR accepted
docs/product/release-readiness.mdatb4e1ded37d4ecf1d43b788cf9d870d3e1020d3ab(PERSONAL-FEISHU-GUIDE,RELEASE-TIMELINE-BASELINE,DSH-PUBLISH-WORKFLOW).PERSONAL-FEISHU-GUIDE: Companion illustrated Feishu doc (https://my.feishu.cn/docx/JXvbdWcFDoZJgvxktvScYfJwnRf) verified owned by the personal user account,anyone_readable, bilingual EN/ZH, containing 3 releasedPyPI loopx==2.4.0UI screenshots (shot-1-overview.png,shot-2-goal.png,shot-3-mobile.png), and linked in both English/Chinese sections ofv2.4.0.mdandrelease-readiness.md.RELEASE-TIMELINE-BASELINE: Appendedv2.4.0timeline entry strictly afterv2.4.0tag,origin/stable, GitHub assets, signeddesktop-stablefeed, PyPI packages, anddsh-loopx-plugin-v0.1.1-beta.7tarball were live, honestly noting npm trusted publishing remains gated on owner npmjs setup.DSH-PUBLISH-WORKFLOW: Preserves immutable-tag source/provenance pinning (actions/checkoutatrefs/tags/${{ inputs.release_tag }},git merge-base --is-ancestor HEAD origin/main,package.jsonversion equality, non-draft release verification, byte-level tarball parity) when dispatched frommainor tag.
改动思路 / Approach
PR #9224 将发布后的收尾文档同步与 dsh-plugin-publish.yml 的最小 CI 修复结合在一起:无需为修复工作流文件而重新打 tag 污染已冻结的 dsh-loopx-plugin-v0.1.1-beta.7(08cb14a0c5 -> a6ffb3be6e),而是允许从 main 手动触发工作流并在第一步即切出不可变 refs/tags/${{ inputs.release_tag }},同时将 DSH_ARTIFACT 修正为 ./output/... 消除 npm 11 包解析歧义。
- Architecture boundary (
retain): Extending the single.github/workflows/dsh-plugin-publish.ymljob condition and checkoutrefwhile keepingDSH_ARTIFACTprefixed with./keeps tag-triggered provenance,git merge-base --is-ancestor HEAD origin/mainchecks, non-draft GitHub release verification, andscripts/verify-distribution.mjsverification under one owner without creating a parallel publish workflow or modifying the frozendsh-loopx-plugin-v0.1.1-beta.7tag. - PR boundary: Scope is strictly limited to
docs/product/releases/v2.4.0.md,docs/product/release-readiness.md,.github/workflows/dsh-plugin-publish.yml,packages/dsh-loopx-plugin/README.md, andtests/test_dsh_plugin_publish_workflow.py(+86 / -5across 5 files); Core/plugin source code andorigin/stableremain untouched (out_of_scope).
具体改动 / Changes
关键代码讲解
-
.github/workflows/dsh-plugin-publish.yml(jobs.publish.ifat L20, checkout at L33-36,DSH_ARTIFACTat L50)- L20 放宽触发分支保护为
github.repository == 'loopx-project/loopx' && ((github.ref_type == 'tag' && github.ref_name == inputs.release_tag) || (github.ref == 'refs/heads/main' && startsWith(inputs.release_tag, 'dsh-loopx-plugin-v')))。 - L35 将
actions/checkout@v7的ref从${{ github.sha }}改为refs/tags/${{ inputs.release_tag }}:即使从main触发以使用最新修好的 workflow 定义,实际检出、祖先校验(git merge-base --is-ancestor HEAD origin/main)、package.json版本校验与产物字段比对仍严格绑定到不可变发布 tag。 - L50 将
DSH_ARTIFACT=output/...改为DSH_ARTIFACT=./output/${manifest.name}-${manifest.version}.tgz。经npm 11.19.0的npm-package-arg实测反例验证:output/dsh-loopx-plugin-0.1.1-beta.7.tgz被解析为type=git(github:output/dsh-loopx-plugin-0.1.1-beta.7.tgz),而./output/dsh-loopx-plugin-0.1.1-beta.7.tgz正确解析为type=file;下游npm publish "$DSH_ARTIFACT"与node scripts/verify-distribution.mjs --tarball "$DSH_ARTIFACT"(通过path.resolve读取文件)均完全兼容。
- L20 放宽触发分支保护为
-
packages/dsh-loopx-plugin/README.md&tests/test_dsh_plugin_publish_workflow.py- README 明确记录可在已发布 plugin tag 或
main上以相同release_tag触发发布工作流,且main触发仍将检出refs/tags/<release_tag>。 - 新增结构单元测试解析
.github/workflows/dsh-plugin-publish.ymlYAML 与README.md,断言 tag/main双入口、startsWith(inputs.release_tag, 'dsh-loopx-plugin-v')、refs/tags/${{ inputs.release_tag }}、git merge-base --is-ancestor HEAD origin/main、DSH_ARTIFACT=./output/...且不存在裸DSH_ARTIFACT=output/正则命中。
- README 明确记录可在已发布 plugin tag 或
-
docs/product/releases/v2.4.0.md&docs/product/release-readiness.md- 在
v2.4.0.md的英文### Upgrade与中文### 升级节补充个人飞书图文指南链接(与线上 GitHub Releasev2.4.0一致)。 - 在
release-readiness.md追加v2.4.0时间线条目,记录a6ffb3be6e7bdb48e02311ec58d618200fe0501c、loopx-runtime-a6ffb3be...tar.gz、LoopX_2.4.0_aarch64.dmg/LoopX.app.zip/LoopX.app.tar.gz、LoopX_2.4.0_x64-setup.exe/LoopX_2.4.0_x64_en-US.msi、PyPI2.4.0与dsh-loopx-plugin 0.1.1-beta.7预发布包链接及 npm Trusted Publishing 前置说明。
- 在
独立复现验证结果 (exact head 90c3fb2cfca8094a41eff9465442b3771a238101)
- 目标测试与脚本验证:
pytest -q tests/test_dsh_plugin_publish_workflow.py:1 passed in 0.58s;ruff check tests/test_dsh_plugin_publish_workflow.py通过。examples/repository-hygiene-smoke.py:repository-hygiene-smoke ok。- 13-surface
examples/release/release-readiness-doc-smoke.py --release-notes docs/product/releases/v2.4.0.md全部通过(release-readiness-doc-smoke ok)。 scripts/check_rfc_bilingual.py对origin/main..HEAD与92271fe114..HEAD均通过;loopx check扫描 5 个修改文件报错0。loopx canary premerge --from-git-diff --git-diff-base origin/main: 在补齐 DSH 插件依赖与pnpm 10.33.0后 19/19 全部通过(5/5direct checks、10/10catalog canaries、8/8risk-profile smokes 含dsh-loopx-pluginquality(15test files /372vitest tests +peer-range+mcp-transport) /package(build+artifact+profile) /runtime(GoalBarruntime smoke)、1/1boundary run,0failures,manual_hold_count: 0)。
- 外部与远端事实独立核验:
git rev-parse 'v2.4.0^{}'与origin/stable均为a6ffb3be6e7bdb48e02311ec58d618200fe0501c;dsh-loopx-plugin-v0.1.1-beta.7^{}为origin/main祖先;GitHub Releasev2.4.0与dsh-loopx-plugin-v0.1.1-beta.7所有引用资产名及 live PyPIloopx==2.4.0文件全部核实存在;线上 GitHub Releasev2.4.0正文已包含JXvbdWcFDoZJgvxktvScYfJwnRf。- 个人飞书文档
JXvbdWcFDoZJgvxktvScYfJwnRf经user身份只读回读验证为个人账户自有、anyone_readable、含 3 张已发布PyPI loopx==2.4.0截图、零私有路径/内部信息。 npm-package-arg反例实测output/...解析为github:output/...,./output/...解析为本地filetarball;Commit DCO 完整,git merge-tree HEAD origin/main干净。
对主干的风险 / Risks
- 首次 npm Trusted Publisher 尚未自动完成(non-blocking, 已披露): 修复
./output/...并合入main后,从main触发dsh-plugin-publish.yml仍依赖仓库维护者在 npmjs.org 上存在包及 Trusted Publisher 绑定;本 PR 已在docs/product/release-readiness.md(L1070-1071)明确标注为前置条件,不夸大自动生效。 - Workflow 触发范围(non-blocking): 当
github.ref == 'refs/heads/main'时,inputs.release_tag仅要求以dsh-loopx-plugin-v开头,随后立即由actions/checkout@v7(refs/tags/${{ inputs.release_tag }})、git merge-base --is-ancestor HEAD origin/main、manifest.version精确比对与非草稿 GitHub Release 校验兜底拦截任意非法/未合入标签,且所有run:步骤均通过RELEASE_TAG环境变量而非 YAML${{ }}文本插值传参,无命令注入风险。 - 远程 CI 未查阅 (
not_consulted): 遵循wait_for_ci: false策略,未轮询或等待远程 GitHub Actions;实际再次在 GitHub Runner 执行dsh-plugin-publish.yml将在本 PR 合入后触发验证。
我的整体评价 / Verdict
Visual review (not_applicable): No dashboard or desktop UI TSX/CSS code changed in PR #9224 (inspected .github/workflows/, docs/product/, packages/dsh-loopx-plugin/README.md, and tests/; separately read back personal Feishu guide XML confirming 3 public-safe PNG image blocks).
PR #9224 完整且准确地完成了 v2.4.0 发布后的文档对齐与关键工作流修复:文档中的 commit SHA、所有平台制品名、PyPI 链接与个人飞书图文指南均经独立只读核验真实可访问且合规;.github/workflows/dsh-plugin-publish.yml 通过 ./output/ 与 refs/tags/${{ inputs.release_tag }} 检出精准根治了 npm v11 误解析与 main 重跑不可变标签难题,并补齐了结构单测与 README 说明。同意合并(已遵守本地优先、不等待远程 CI 的评审策略)。
English verdict: APPROVE on exact head 90c3fb2: accurately records the live v2.4.0 release ledger and personally owned illustrated Feishu guide across bilingual docs, fixes npm 11 tarball path parsing with ./output/ while preserving immutable tag checkout and ancestor/version checks on main workflow_dispatch, adds regression test coverage, and passes all local tests, npm-package-arg counterfactual, DSH quality/package/runtime validations, and canary premerge gates.
Delivery Summary
v2.4.0documentation sync onmainand DSH npm publish workflow fix afterorigin/stable, PyPIloopx==2.4.0, GitHub Releasev2.4.0, DSH prereleasedsh-loopx-plugin-v0.1.1-beta.7, and the personal illustrated Feishu upgrade guide (https://my.feishu.cn/docx/JXvbdWcFDoZJgvxktvScYfJwnRf) went live.docs/product/releases/v2.4.0.mdanddocs/product/release-readiness.mdneeded the personal Feishuv2.4.0guide links and verifiedv2.4.0ledger entry..github/workflows/dsh-plugin-publish.yml(failed on run44954216246) setDSH_ARTIFACT=output/...without a leading./, causingnpm publishon Node 24 / npm 11 to interpretoutput/dsh-loopx-plugin-0.1.1-beta.7.tgzas GitHub repo shorthand (ssh://[email protected]/output/..., exit128), and restrictedworkflow_dispatchto tag refs so a workflow fix onmaincould not target an immutable earlier tag.[Illustrated Feishu upgrade guide](https://my.feishu.cn/docx/JXvbdWcFDoZJgvxktvScYfJwnRf)under### Upgradeand[飞书图文升级与验收指南](https://my.feishu.cn/docx/JXvbdWcFDoZJgvxktvScYfJwnRf)under## 中文摘要 -> ### 升级indocs/product/releases/v2.4.0.md.v2.4.0timeline entry indocs/product/release-readiness.mdciting commita6ffb3be6e7bdb48e02311ec58d618200fe0501c, signeddesktop-stablemacOS updater + Windows installers, PyPI packages,DSH plugin 0.1.1-beta.7prerelease, and Personal illustrated guide (https://my.feishu.cn/docx/JXvbdWcFDoZJgvxktvScYfJwnRf)..github/workflows/dsh-plugin-publish.yml(DSH_ARTIFACT=./output/${manifest.name}-${manifest.version}.tgz,actions/checkout@v7pinned torefs/tags/${{ inputs.release_tag }},publish.ifallowing exact tag orrefs/heads/mainwithstartsWith(inputs.release_tag, 'dsh-loopx-plugin-v')), documentedmaindispatch inpackages/dsh-loopx-plugin/README.md, and addedtests/test_dsh_plugin_publish_workflow.py.docs/product/releases/v2.4.0.md,docs/product/release-readiness.md), DSH publish workflow/docs (.github/workflows/dsh-plugin-publish.yml,packages/dsh-loopx-plugin/README.md), and workflow unit test (tests/test_dsh_plugin_publish_workflow.py).origin/stableremains untouched ata6ffb3be6e7bdb48e02311ec58d618200fe0501c.Validation & Qualification Evidence
pytest -q tests/test_dsh_plugin_publish_workflow.py: passed (1 passed)ruff check tests/test_dsh_plugin_publish_workflow.py: passedpython examples/repository-hygiene-smoke.py: passed (repository-hygiene-smoke ok)examples/release/release-readiness-doc-smoke.py --release-notes docs/product/releases/v2.4.0.md(13 surfaces): passed (release-readiness-doc-smoke ok)scripts/check_rfc_bilingual.py --base origin/main --head HEAD: passedloopx check --scan-path ...(all 5 changed files): passed (errors=0, warnings=0)cqr_d7e2aee947fcebdcd742(status: valid,scope_fingerprint: d7e2aee947fcebdcd742d0a18cacde67d166516e3ff1ec38187d9f578beb900c,safe_fix_applied: false)loopx canary premerge --from-git-diff --git-diff-base origin/main --goal-id personal-loopx-maintenanceagainst90c3fb2cfca8094a41eff9465442b3771a238101: passed (status: passed,merge_gate_passed: true,5/5direct checks +10/10catalog canaries +8/8risk-profile smokes includingdsh-loopx-pluginquality/package/runtime+1/1public boundary scan;0failures,0manual holds)