Skip to content

docs(release): record v2.4.0 baseline, Feishu guide link, and DSH publish workflow fix - #9224

Merged
loopx-agent merged 2 commits into
mainfrom
codex/v240-post-release-docs-20261121
Nov 21, 2026
Merged

loopx-agent merged 2 commits into
mainfrom
codex/v240-post-release-docs-20261121

Conversation

@loopx-agent

@loopx-agent loopx-agent commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Delivery Summary

  • Goal / source: Post-release v2.4.0 documentation sync on main and DSH npm publish workflow fix after origin/stable, PyPI loopx==2.4.0, GitHub Release v2.4.0, DSH prerelease dsh-loopx-plugin-v0.1.1-beta.7, and the personal illustrated Feishu upgrade guide (https://my.feishu.cn/docx/JXvbdWcFDoZJgvxktvScYfJwnRf) went live.
  • Current gap:
    1. docs/product/releases/v2.4.0.md and docs/product/release-readiness.md needed the personal Feishu v2.4.0 guide links and verified v2.4.0 ledger entry.
    2. .github/workflows/dsh-plugin-publish.yml (failed on run 44954216246) set DSH_ARTIFACT=output/... without a leading ./, causing npm publish on Node 24 / npm 11 to interpret output/dsh-loopx-plugin-0.1.1-beta.7.tgz as GitHub repo shorthand (ssh://[email protected]/output/..., exit 128), and restricted workflow_dispatch to tag refs so a workflow fix on main could not target an immutable earlier tag.
  • Observable result:
    • Added [Illustrated Feishu upgrade guide](https://my.feishu.cn/docx/JXvbdWcFDoZJgvxktvScYfJwnRf) under ### Upgrade and [飞书图文升级与验收指南](https://my.feishu.cn/docx/JXvbdWcFDoZJgvxktvScYfJwnRf) under ## 中文摘要 -> ### 升级 in docs/product/releases/v2.4.0.md.
    • Appended the verified v2.4.0 timeline entry in docs/product/release-readiness.md citing commit a6ffb3be6e7bdb48e02311ec58d618200fe0501c, signed desktop-stable macOS updater + Windows installers, PyPI packages, DSH plugin 0.1.1-beta.7 prerelease, and Personal illustrated guide (https://my.feishu.cn/docx/JXvbdWcFDoZJgvxktvScYfJwnRf).
    • Updated .github/workflows/dsh-plugin-publish.yml (DSH_ARTIFACT=./output/${manifest.name}-${manifest.version}.tgz, actions/checkout@v7 pinned to refs/tags/${{ inputs.release_tag }}, publish.if allowing exact tag or refs/heads/main with startsWith(inputs.release_tag, 'dsh-loopx-plugin-v')), documented main dispatch in packages/dsh-loopx-plugin/README.md, and added tests/test_dsh_plugin_publish_workflow.py.
  • Owning boundary: Docs (docs/product/releases/v2.4.0.md, docs/product/release-readiness.md), DSH publish workflow/docs (.github/workflows/dsh-plugin-publish.yml, packages/dsh-loopx-plugin/README.md), and workflow unit test (tests/test_dsh_plugin_publish_workflow.py). origin/stable remains untouched at a6ffb3be6e7bdb48e02311ec58d618200fe0501c.

Validation & Qualification Evidence

  • pytest -q tests/test_dsh_plugin_publish_workflow.py: passed (1 passed)
  • ruff check tests/test_dsh_plugin_publish_workflow.py: passed
  • python examples/repository-hygiene-smoke.py: passed (repository-hygiene-smoke ok)
  • examples/release/release-readiness-doc-smoke.py --release-notes docs/product/releases/v2.4.0.md (13 surfaces): passed (release-readiness-doc-smoke ok)
  • scripts/check_rfc_bilingual.py --base origin/main --head HEAD: passed
  • loopx check --scan-path ... (all 5 changed files): passed (errors=0, warnings=0)
  • Change Quality Receipt: cqr_d7e2aee947fcebdcd742 (status: valid, scope_fingerprint: d7e2aee947fcebdcd742d0a18cacde67d166516e3ff1ec38187d9f578beb900c, safe_fix_applied: false)
  • loopx canary premerge --from-git-diff --git-diff-base origin/main --goal-id personal-loopx-maintenance against 90c3fb2cfca8094a41eff9465442b3771a238101: passed (status: passed, merge_gate_passed: true, 5/5 direct checks + 10/10 catalog canaries + 8/8 risk-profile smokes including dsh-loopx-plugin quality/package/runtime + 1/1 public boundary scan; 0 failures, 0 manual holds)

@loopx-agent loopx-agent changed the title docs(release): record v2.4.0 release baseline and Feishu guide link docs(release): record v2.4.0 baseline, Feishu guide link, and DSH publish workflow fix Nov 21, 2026

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent · Gemini · Google · self_reported

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

This exact-head review of PR #9224 (9224@90c3fb2cfca8094a41eff9465442b3771a238101) approves the post-release v2.4.0 documentation synchronization and the .github/workflows/dsh-plugin-publish.yml artifact-path and main-dispatch repair.

动机 / Motivation

Operators upgrading to LoopX 2.4.0 or publishing existing DSH plugin releases from GitHub Actions hit two post-release documentation and automation gaps after v2.4.0 shipped at a6ffb3be6e7bdb48e02311ec58d618200fe0501c.

Before this change, docs/product/releases/v2.4.0.md and docs/product/release-readiness.md lacked links to the verified v2.4.0 release record and illustrated Feishu upgrade guide (https://my.feishu.cn/docx/JXvbdWcFDoZJgvxktvScYfJwnRf), and .github/workflows/dsh-plugin-publish.yml exported DSH_ARTIFACT=output/... without a leading ./ (causing npm v11 on Node 24 to treat output/dsh-loopx-plugin-0.1.1-beta.7.tgz as GitHub shorthand ssh://[email protected]/output/... and fail run 44954216246 with exit 128) while blocking workflow_dispatch from main so a fixed workflow on main could not republish an earlier immutable plugin tag; after this change, the bilingual release note and release-readiness timeline cite the verified v2.4.0 artifacts and personal Feishu guide, and the publish workflow prefixes ./output/ while permitting main dispatches whose checkout remains pinned to refs/tags/<release_tag>.

Observably, independent checks confirm v2.4.0 and origin/stable resolve to a6ffb3be6e7bdb48e02311ec58d618200fe0501c, PyPI loopx==2.4.0 and all listed release assets are live, the personal Feishu guide (JXvbdWcFDoZJgvxktvScYfJwnRf) is publicly readable (anyone_readable) with 3 public-safe 2.4.0 interface screenshots, npm's package argument parser resolves ./output/... as a local file tarball instead of github: git shorthand, and the added workflow test plus full DSH plugin validation pass.

This PR covers only post-release v2.4.0 docs links, the DSH npm publish workflow fix, its README clarification, and its workflow structural test; it does not modify origin/stable, rebuild plugin/Core binaries, or grant npm registry ownership/Trusted Publisher setup.

  • Specification basis: Evaluated against the pre-PR accepted docs/product/release-readiness.md at b4e1ded37d4ecf1d43b788cf9d870d3e1020d3ab (PERSONAL-FEISHU-GUIDE, RELEASE-TIMELINE-BASELINE, DSH-PUBLISH-WORKFLOW).
    • PERSONAL-FEISHU-GUIDE: Companion illustrated Feishu doc (https://my.feishu.cn/docx/JXvbdWcFDoZJgvxktvScYfJwnRf) verified owned by the personal user account, anyone_readable, bilingual EN/ZH, containing 3 released PyPI loopx==2.4.0 UI screenshots (shot-1-overview.png, shot-2-goal.png, shot-3-mobile.png), and linked in both English/Chinese sections of v2.4.0.md and release-readiness.md.
    • RELEASE-TIMELINE-BASELINE: Appended v2.4.0 timeline entry strictly after v2.4.0 tag, origin/stable, GitHub assets, signed desktop-stable feed, PyPI packages, and dsh-loopx-plugin-v0.1.1-beta.7 tarball were live, honestly noting npm trusted publishing remains gated on owner npmjs setup.
    • DSH-PUBLISH-WORKFLOW: Preserves immutable-tag source/provenance pinning (actions/checkout at refs/tags/${{ inputs.release_tag }}, git merge-base --is-ancestor HEAD origin/main, package.json version equality, non-draft release verification, byte-level tarball parity) when dispatched from main or tag.

改动思路 / Approach

PR #9224 将发布后的收尾文档同步与 dsh-plugin-publish.yml 的最小 CI 修复结合在一起:无需为修复工作流文件而重新打 tag 污染已冻结的 dsh-loopx-plugin-v0.1.1-beta.7(08cb14a0c5 -> a6ffb3be6e),而是允许从 main 手动触发工作流并在第一步即切出不可变 refs/tags/${{ inputs.release_tag }},同时将 DSH_ARTIFACT 修正为 ./output/... 消除 npm 11 包解析歧义。

  1. Architecture boundary (retain): Extending the single .github/workflows/dsh-plugin-publish.yml job condition and checkout ref while keeping DSH_ARTIFACT prefixed with ./ keeps tag-triggered provenance, git merge-base --is-ancestor HEAD origin/main checks, non-draft GitHub release verification, and scripts/verify-distribution.mjs verification under one owner without creating a parallel publish workflow or modifying the frozen dsh-loopx-plugin-v0.1.1-beta.7 tag.
  2. PR boundary: Scope is strictly limited to docs/product/releases/v2.4.0.md, docs/product/release-readiness.md, .github/workflows/dsh-plugin-publish.yml, packages/dsh-loopx-plugin/README.md, and tests/test_dsh_plugin_publish_workflow.py (+86 / -5 across 5 files); Core/plugin source code and origin/stable remain untouched (out_of_scope).

具体改动 / Changes

关键代码讲解

  1. .github/workflows/dsh-plugin-publish.yml (jobs.publish.if at L20, checkout at L33-36, DSH_ARTIFACT at L50)

    • L20 放宽触发分支保护为 github.repository == 'loopx-project/loopx' && ((github.ref_type == 'tag' && github.ref_name == inputs.release_tag) || (github.ref == 'refs/heads/main' && startsWith(inputs.release_tag, 'dsh-loopx-plugin-v')))。
    • L35 将 actions/checkout@v7 的 ref 从 ${{ github.sha }} 改为 refs/tags/${{ inputs.release_tag }}:即使从 main 触发以使用最新修好的 workflow 定义,实际检出、祖先校验(git merge-base --is-ancestor HEAD origin/main)、package.json 版本校验与产物字段比对仍严格绑定到不可变发布 tag。
    • L50 将 DSH_ARTIFACT=output/... 改为 DSH_ARTIFACT=./output/${manifest.name}-${manifest.version}.tgz。经 npm 11.19.0 的 npm-package-arg 实测反例验证:output/dsh-loopx-plugin-0.1.1-beta.7.tgz 被解析为 type=git (github:output/dsh-loopx-plugin-0.1.1-beta.7.tgz),而 ./output/dsh-loopx-plugin-0.1.1-beta.7.tgz 正确解析为 type=file;下游 npm publish "$DSH_ARTIFACT" 与 node scripts/verify-distribution.mjs --tarball "$DSH_ARTIFACT"(通过 path.resolve 读取文件)均完全兼容。
  2. packages/dsh-loopx-plugin/README.md & tests/test_dsh_plugin_publish_workflow.py

    • README 明确记录可在已发布 plugin tag 或 main 上以相同 release_tag 触发发布工作流,且 main 触发仍将检出 refs/tags/<release_tag>。
    • 新增结构单元测试解析 .github/workflows/dsh-plugin-publish.yml YAML 与 README.md,断言 tag/main 双入口、startsWith(inputs.release_tag, 'dsh-loopx-plugin-v')、refs/tags/${{ inputs.release_tag }}、git merge-base --is-ancestor HEAD origin/main、DSH_ARTIFACT=./output/... 且不存在裸 DSH_ARTIFACT=output/ 正则命中。
  3. docs/product/releases/v2.4.0.md & docs/product/release-readiness.md

    • 在 v2.4.0.md 的英文 ### Upgrade 与中文 ### 升级 节补充个人飞书图文指南链接(与线上 GitHub Release v2.4.0 一致)。
    • 在 release-readiness.md 追加 v2.4.0 时间线条目,记录 a6ffb3be6e7bdb48e02311ec58d618200fe0501c、loopx-runtime-a6ffb3be...tar.gz、LoopX_2.4.0_aarch64.dmg / LoopX.app.zip / LoopX.app.tar.gz、LoopX_2.4.0_x64-setup.exe / LoopX_2.4.0_x64_en-US.msi、PyPI 2.4.0 与 dsh-loopx-plugin 0.1.1-beta.7 预发布包链接及 npm Trusted Publishing 前置说明。

独立复现验证结果 (exact head 90c3fb2cfca8094a41eff9465442b3771a238101)

  • 目标测试与脚本验证:
    • pytest -q tests/test_dsh_plugin_publish_workflow.py: 1 passed in 0.58s;ruff check tests/test_dsh_plugin_publish_workflow.py 通过。
    • examples/repository-hygiene-smoke.py: repository-hygiene-smoke ok。
    • 13-surface examples/release/release-readiness-doc-smoke.py --release-notes docs/product/releases/v2.4.0.md 全部通过(release-readiness-doc-smoke ok)。
    • scripts/check_rfc_bilingual.py 对 origin/main..HEAD 与 92271fe114..HEAD 均通过;loopx check 扫描 5 个修改文件报错 0。
    • loopx canary premerge --from-git-diff --git-diff-base origin/main: 在补齐 DSH 插件依赖与 pnpm 10.33.0 后 19/19 全部通过(5/5 direct checks、10/10 catalog canaries、8/8 risk-profile smokes 含 dsh-loopx-plugin quality (15 test files / 372 vitest tests + peer-range + mcp-transport) / package (build + artifact + profile) / runtime (GoalBar runtime smoke)、1/1 boundary run,0 failures,manual_hold_count: 0)。
  • 外部与远端事实独立核验:
    • git rev-parse 'v2.4.0^{}' 与 origin/stable 均为 a6ffb3be6e7bdb48e02311ec58d618200fe0501c;dsh-loopx-plugin-v0.1.1-beta.7^{} 为 origin/main 祖先;GitHub Release v2.4.0 与 dsh-loopx-plugin-v0.1.1-beta.7 所有引用资产名及 live PyPI loopx==2.4.0 文件全部核实存在;线上 GitHub Release v2.4.0 正文已包含 JXvbdWcFDoZJgvxktvScYfJwnRf。
    • 个人飞书文档 JXvbdWcFDoZJgvxktvScYfJwnRf 经 user 身份只读回读验证为个人账户自有、anyone_readable、含 3 张已发布 PyPI loopx==2.4.0 截图、零私有路径/内部信息。
    • npm-package-arg 反例实测 output/... 解析为 github:output/...,./output/... 解析为本地 file tarball;Commit DCO 完整,git merge-tree HEAD origin/main 干净。

对主干的风险 / Risks

  • 首次 npm Trusted Publisher 尚未自动完成(non-blocking, 已披露): 修复 ./output/... 并合入 main 后,从 main 触发 dsh-plugin-publish.yml 仍依赖仓库维护者在 npmjs.org 上存在包及 Trusted Publisher 绑定;本 PR 已在 docs/product/release-readiness.md(L1070-1071)明确标注为前置条件,不夸大自动生效。
  • Workflow 触发范围(non-blocking): 当 github.ref == 'refs/heads/main' 时,inputs.release_tag 仅要求以 dsh-loopx-plugin-v 开头,随后立即由 actions/checkout@v7(refs/tags/${{ inputs.release_tag }})、git merge-base --is-ancestor HEAD origin/main、manifest.version 精确比对与非草稿 GitHub Release 校验兜底拦截任意非法/未合入标签,且所有 run: 步骤均通过 RELEASE_TAG 环境变量而非 YAML ${{ }} 文本插值传参,无命令注入风险。
  • 远程 CI 未查阅 (not_consulted): 遵循 wait_for_ci: false 策略,未轮询或等待远程 GitHub Actions;实际再次在 GitHub Runner 执行 dsh-plugin-publish.yml 将在本 PR 合入后触发验证。

我的整体评价 / Verdict

Visual review (not_applicable): No dashboard or desktop UI TSX/CSS code changed in PR #9224 (inspected .github/workflows/, docs/product/, packages/dsh-loopx-plugin/README.md, and tests/; separately read back personal Feishu guide XML confirming 3 public-safe PNG image blocks).

PR #9224 完整且准确地完成了 v2.4.0 发布后的文档对齐与关键工作流修复:文档中的 commit SHA、所有平台制品名、PyPI 链接与个人飞书图文指南均经独立只读核验真实可访问且合规;.github/workflows/dsh-plugin-publish.yml 通过 ./output/ 与 refs/tags/${{ inputs.release_tag }} 检出精准根治了 npm v11 误解析与 main 重跑不可变标签难题,并补齐了结构单测与 README 说明。同意合并(已遵守本地优先、不等待远程 CI 的评审策略)。

English verdict: APPROVE on exact head 90c3fb2: accurately records the live v2.4.0 release ledger and personally owned illustrated Feishu guide across bilingual docs, fixes npm 11 tarball path parsing with ./output/ while preserving immutable tag checkout and ancestor/version checks on main workflow_dispatch, adds regression test coverage, and passes all local tests, npm-package-arg counterfactual, DSH quality/package/runtime validations, and canary premerge gates.

@loopx-agent
loopx-agent merged commit 06fd6fe into main Nov 21, 2026
17 of 41 checks passed
@loopx-agent
loopx-agent deleted the codex/v240-post-release-docs-20261121 branch November 21, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant