Skip to content

Read canonical test worker replies through portable pipes - #9218

Open
loopx-agent wants to merge 1 commit into
mainfrom
codex/canonical-fixture-windows-pipe-20261121
Open

loopx-agent wants to merge 1 commit into
mainfrom
codex/canonical-fixture-windows-pipe-20261121

Conversation

@loopx-agent

Copy link
Copy Markdown
Collaborator

Goal and scope

The Windows research fixture tests fail before they can read the saved results. Python's Windows selector rejects the canonical test worker's anonymous stdout pipe with WinError 10038. The failing job exercised four research fixtures through the same worker. Windows job on PR #9204

The worker now reads complete UTF-8 response lines through a thread and a queue owned by the child process. It retains the response deadline and the existing recovery for an exited child. When a child stays silent, the worker reaps it and reports the timeout. The regression test uses a real subprocess to verify that the worker does not replay a timed-out request.

Validation

Tested commit 7b9ccbe against main.

  • Seventeen macOS tests passed with PYTHONUTF8=0. They cover saved research results over HTTP, real File and SQLite setup, child respawn, and the timeout.
  • A local probe emulated a socket-only selector. It reproduced the original failure and verified large split UTF-8 replies, subsequent requests, incomplete response handling and child cleanup with the candidate.
  • Ruff, the bilingual RFC gate and standard premerge passed.
  • The existing hosted Windows lane will run the native qualification.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant