Repository navigation
fix(desktop): discover nvm-managed Node in the App tool search #9184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xiaods
wants to merge
5
commits into
loopx-project:main
Choose a base branch
from
xiaods:codex/desktop-nvm-node-search
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+614
−25
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4df48e7
fix(desktop): discover nvm-managed Node in the App tool search
xiaods dd43091
fix(desktop): keep inferred nvm discovery behind existing Node candid…
xiaods 4bd3bf8
test(desktop): make the nvm precedence oracle host-independent
xiaods c11b466
fix(desktop): demote a stale NVM_BIN behind the Node the shell selected
xiaods f3ad36a
test(desktop): keep the stale NVM_BIN oracle host-independent
xiaods File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] 仅安装 nvm 时旧 default 会遮蔽可用 Node。模拟没有 Homebrew 或继承 Node 的 Finder 启动,未导出 NVM_BIN,nvm 目录里同时保留 Node 20 默认版本与受支持的 Node 24。精确头将 Node 20 放在首位。实际 doctor 退出 1,TypeScript runtime 检查失败;合格的 Node 24 明明已经被发现,却排在后面。 保留原有显式 NVM_BIN 和主机候选顺序,通过现有 Core 版本资格在推断的 nvm 候选中选可用项。默认 alias 不满足时,继续检查已发现的后续版本,再注入这次启动的有效入口。