Repository navigation
feat(control-plane): assess scope budget proportionality without blocking large features - #8945
loopx-agent wants to merge 1 commit into
Conversation
d2147d4 to
43a8ad6
Compare
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent | self_reported | Gemini | Google DeepMind
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
动机 / Motivation
维护与评审 LoopX 控制面仓库的自动巡检 Agent、代码评审员与长程研发分支维护者。
此前缺少硬门禁阻止超大净膨胀、反复合入主干及多次返工打乒乓球的 PR 不断堆积(典型参考体量如 300 文件/+27,420/-4,938/13 merge commits),且 review_order=reverse 会把持续追加提交的巨无霸 PR 反排至队列首位并允许通过核验;合入本机制后,单一 TS owner 自动判定 accretion_hold,阻断 change-quality 验收、阻断非拆分/非简化结论并通过 orderPrReviewQueue 将其后置到所有有界 PR 之后。
在 TypeScript 控制面新增单源 owner capabilities.change_scope_budget.assess,联动 Python change-quality 与 pr-review 排队/结论校验门禁(同时豁免 deletions > additions 且 additions <= 1500 的净减法清理 PR)。
非目标边界:本 PR 不直接重写或关闭远端既有开放 PR,也不改变常规有界 PR 或净减法清理 PR 的审查顺序与通过标准。
若仅靠人工口头劝退,巨无霸 PR 会持续吸收并行开发精力并挟持评审队列第一位;把“停扩建并按基线拆分”固化进机械控制面后,开发准出与评审排序协同拦截打乒乓球式膨胀。
改动思路 / Approach
将 diff 规模、提交震荡、合入主干次数与返工轮次的阈值判定收敛进唯一纯函数 TypeScript 决策 owner(change_scope_budget.ts),开发态 change_quality 与评审态 pr_review_queue 仅作薄适配器与强制执行器,避免双轨口徑漂移。
当前 PR 边界:仅限 change_scope_budget 单源合同及其对 change_quality、pr_review_queue、result_check 与对应技能说明的机械接入(22 文件 +1062/-34,0 新增顶层 Python 模块,其中 494 行为测试/tsconfig)。
- 单源决策不变量(
assessChangeScopeBudget):所有状态值(within_budget/net_subtraction/elevated_scope/accretion_hold)及触发信号均在loopx/control_plane/capabilities/change_scope_budget.ts纯函数计算,拒绝任何不支持字段与负整数输入;优先判定净减法豁免(deletions > additions && additions <= 1500)。 - 队列抗劫持不变量(
orderPrReviewQueue):forward与reverse(owner-first)均先把boundedActionable排在最前,再排accretion_hold,最后排inactive,彻底消除倒序反转后超大 PR 跃居 Rank #1 的漏洞。 - 开发/评审双门禁协同:
change_quality通过_GUARDRAIL_QUALIFICATION_PREFIXES将scope_budget:accretion_hold映射到efficiency阻断;result_check.py在split_required=True时仅允许change_proportionality.verdict == "disproportionate"或architecture_assessment.decision == "simplify_now"通过--check-result。 - 实盘验证:在本 PR worktree 中直接对仓内现存超大 PR
#8266运行loopx pr-review --target-exact-head,实测返回accretion_hold并触发全 4 项信号(changed_files=300, additions=27420, deletions=4938, merge_commit_count=13, request_changes_rounds=97),而本 PR 自身被正确归类为elevated_scope(非阻塞)。
具体改动 / Changes
依据既有规范 docs/architecture/rfcs/controller-executor-unified-contract-v0.md(修订 ef099ae3ac3c08054b9d928fff48aefe2615b950)核对核心准则:
SUB-GATE-SCOPE-OWNER:阈值策略由单一 TS 纯函数 ownercapabilities.change_scope_budget.assess统筹,无 Python 并行策略拷贝(经 TS 单测 24/24 与 Pytest 281 passed 验证 PASS)。SUB-GATE-ANTI-PINBALL:change_quality与pr_review_queue对accretion_hold强制阻断常规批准并保留净减法 PR 豁免(经 livechange-quality prepare与 livepr-review #8266实测 PASS)。
关键代码讲解
loopx/control_plane/capabilities/change_scope_budget.ts:50(assessChangeScopeBudget):以闭合状态枚举CHANGE_SCOPE_BUDGET_STATUSES归类差分,先豁免net_subtraction,再校验 4 路accretion_hold阈值及 4 路elevated_scope警告。loopx/capabilities/change_quality/scope.py:302&loopx/capabilities/change_quality/result.py:486:scope.py用git diff --numstat -z与rev-list统计真实规模并调用 TS 能力;result.py通过映射表将scope_budget:accretion_hold归入efficiency阻断门禁。loopx/control_plane/capabilities/pr_review_order.ts:109(orderPrReviewQueue):独立拆分boundedActionable与holdActionable,确保在reverse模式下也仅在各自组内逆序,不让accretion_hold抢占首位。loopx/capabilities/pr_review_queue/scope_budget.py:93&loopx/capabilities/pr_review_queue/result_check.py:594:scope_budget.py解析 GraphQL/list 格式提交数、Merge commit 与返工轮次;result_check.py强制禁止对accretion_holdPR 给出非拆分式通关评价。
对主干的风险 / Risks
- 范围扩张自我评估(elevated_scope 非阻断):本 PR 改动 22 文件(
+1062/-34),包含完整 TS 合同 + 双侧 Python 适配器 + 494 行全量单测与文档;全部集中在同一闭环门禁内,0 新增顶层loopx/*.py文件。 - 可逆性与假阳性风险:阈值均集中在
change_scope_budget.ts:79-119,若极端合理重构触发警告或持留,net_subtraction先行豁免且作者也可显式拆片;实测本 PR 本身(22 文件/+1062)与独立瘦身 PR 均不被误判为accretion_hold。scope.py对未提交工作区多阶段相加略保守,但在整洁提交态准确;pr_review.py:1014摘要scale字段沿用 PR 头统计,仅当缺失头统计的 fixture 场景下与scope_budget采用的files回退求和略有差异,均为非阻塞细节。 - 远端 CI 说明:远端 Actions 上
kernel-static-checks报错系基底origin/main的tests/control_plane/test_contract_health.py:10F401(已由测试清理分支定位并修复),本 PR 修改路径本地校验全部绿灯。
| 验证项 | 级别 | 结果 | 实跑输出(exact head 43a8ad619b63452c4cb008bf6d982c743c93d7b3) |
|---|---|---|---|
pytest -q tests/capabilities/test_change_quality.py tests/capabilities/test_pr_review_agent_order.py tests/capabilities/test_pr_review_result_check.py tests/architecture/test_top_level_module_budget.py |
required | PASS | 281 passed in 10.19s |
node --experimental-strip-types --test tests/control_plane_ts/change_scope_budget.test.ts tests/control_plane_ts/change_quality_validation.test.ts |
required | PASS | 24 passed, 0 failed |
tsc --noEmit -p tsconfig.control-plane.json & ruff check ... |
required | PASS | tsc rc=0; ruff All checks passed! |
loopx canary premerge --from-git-diff --git-diff-base origin/main --tier quick |
required | PASS | selected_checks: 3, executed_checks: 3, failures: 0 (ok: true) |
实盘 CLI 对真实 PR #8266 与自身 change-quality prepare 校验 |
required | PASS | #8266 -> accretion_hold (split_required=true, accretion_hold=true); 自身 -> elevated_scope |
远端 GitHub Checks(kernel-static-checks 等) |
diagnostic (required=false) |
FAIL (unrelated) | 基线 tests/control_plane/test_contract_health.py:10 F401 预存故障 |
我的整体评价 / Verdict
对精确 head 43a8ad619b63452c4cb008bf6d982c743c93d7b3 的评价:用户体验影响为 not_applicable(仅涉及控制面 TS 契约、CLI JSON 门禁与 SKILL Markdown 说明,未改动前端页面、CSS 布局或浏览器交互渲染(inspected: loopx/control_plane/capabilities/change_scope_budget.ts, loopx/pr_review.py)。,unverified_scope: none),长程工程效率 improved。语义词汇方面本 PR 在 tsconfig.control-plane.json 纳管下于 change_scope_budget.ts 新增闭合状态常量 CHANGE_SCOPE_BUDGET_STATUSES 承载开发与评审双侧统一状态契约(semantic_alignment=new_semantics_justified),无冗余旧别名或兼容垫片(compatibility_assessment=not_applicable)。本地全量 Python/TS 单测、类型检查、ruff、canary 与对真实超大 PR #8266 的实盘测试全部 PASS,同意合入。
English verdict: APPROVE
…king large features Signed-off-by: LoopX Agent <[email protected]>
43a8ad6 to
b2261a5
Compare
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent · Gemini · Google (self_reported)
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
已针对 PR #8945 exact head b2261a535e8a3008c145b88999b56436989db3fa 完成完整重审与本地验证(审查结论:APPROVE,无 P0/P1/P2 问题)。
动机 / Motivation
受影响调用方与维护者:所有使用 change-quality(loopx/capabilities/change_quality/)和 pr-review(loopx/pr_review.py、loopx/capabilities/pr_review_queue/)推进或评审大型 Feature 开发、跨模块重建与多轮代码迭代的开发者与评审 Agent,以及对应 skills/loopx-change-quality / skills/loopx-pr-review 使用方。
修改前(早期草稿 43a8ad61 及 origin/main 513b6f16):origin/main 缺乏统一的工作区/PR 变更规模与返工信号评估;而早期方案以 accretion_hold(split_required=true)对 additions >= 2500 && changed_files >= 35、request_changes_rounds >= 5、commit_count >= 40 或 merge_commit_count >= 3 做硬性阻断,会在大型 Feature 开发场景下卡死 change-quality 收据、在评审队列中将大 PR 压到末尾并禁止 --check-result 给出 proportionate / APPROVE。修改后(b2261a535e):保留基于 origin/main 合并的单一 TS 控制面所有者 change_scope_budget_assessment_v0,将上述 4 类高规模/多轮信号收敛为非阻断诊断态 large_scope(remediation="verify_goal_proportionality"),既持续提醒核验是否存在无意垫片或范围漂移,又完整放行合理大型 Feature 的 change-quality 通过、正常队列排序与 APPROVE。
可观测结果:TS 控制面 tsc --noEmit -p tsconfig.control-plane.json 退出码 0、node --experimental-strip-types --test 23 passed, 0 failed;Python mypy --strict --follow-imports=silent loopx/capabilities/pr_review_queue/scope_budget.py 与全仓 mypy(17 个文件)报 0 错误、ruff check 全过、pytest -q -n 4(6 组 测试文件)419 passed in 22.88s(0 skipped)、examples/pr-review-command-smoke.py 输出 pr-review-command-smoke ok、loopx canary premerge --tier quick --from-git-diff --git-diff-base origin/main 返回 passed(ok=true, selected=3, failures=0)、loopx check --scan-path ...(18 文件)报 errors=0, warnings=0。
非目标边界:本 PR 不基于原始提交数、主干合并次数、diff 行数或评审轮次做机械拆片锁定或队列降权,不修改既有无 scope_budget 调用方的 qualifyChangeQualityValidation 行为,不新增硬性门禁外的外置调度服务,亦不授予作者自有运行时合入权限。
改动思路 / Approach
本次收敛在单一 TypeScript 控制面契约 loopx/control_plane/capabilities/change_scope_budget.ts(change_scope_budget_assessment_v0)上统一定义范围预算状态机 CHANGE_SCOPE_BUDGET_STATUSES = ["within_budget", "net_subtraction", "elevated_scope", "large_scope"],通过 loopx/control_plane/effect_runtime_handlers.ts 对 change-quality 和 pr-review 两套 Python 能力适配器提供无副作用的一致分类,避免在两条链路分别硬编码阈值。
当前 PR 边界:范围精确限定在 change_scope_budget.ts 评估契约、change_quality_validation.ts 非阻断 risk_codes 映射、change_quality/{scope,receipt,result}.py、pr_review_queue/{scope_budget,core,review_contract}.py、pr_review.py 非阻断提示、skills/loopx-{change-quality,pr-review}/SKILL.md 适配说明与对应单测;已按维护者明确方向移除对 pr_review_order.ts、order.py、scheduling.py 与 result_check.py 的硬性队列惩罚与 APPROVE 封锁。
- TS 范围预算契约收敛(
loopx/control_plane/capabilities/change_scope_budget.ts:14-142、change_quality_validation.ts:113-122):定义large_scope(remediation="verify_goal_proportionality")及elevated_scope("prefer_smaller_slice"),移除split_required;两者均仅写入risk_codes("scope_budget:large_scope"/"scope_budget:elevated_scope"),绝不写入blocking_codes;净减行清理(deletions > additions && additions <= 1500)继续走net_subtraction豁免。 - 开发质检集成(
loopx/capabilities/change_quality/scope.py:302-349、receipt.py:193-228、result.py:486-525):统计相对base_ref的増删行与提交/合并计数后注入scope_budget;命中large_scope时在prepare指令中要求作者核验是否匹配目标边界而无意外垫片,并在record保持decision="pass"与guardrail.status="risk"。 - PR 评审适配器与提示词对齐(
loopx/capabilities/pr_review_queue/scope_budget.py:1-143、review_contract.py:1162-1168,1530-1535、loopx/pr_review.py:219-236,954-1019):零Any实现assess_pr_scope_budget、is_large_scope与pr_scope_budget_risk_note;保持pr_review公平排序与APPROVE/proportionate资格,同时明确指导在真实出现冗余垫片或范围漂移时仍可给出disproportionate/simplify_now;同步更新两份 Skill(skills/loopx-pr-review/SKILL.md严格维持190行以内)。
具体改动 / Changes
本次 single-commit rebase 触及 18 个文件(987 insertions(+), 12 deletions(-)):
- TS 控制面:
loopx/control_plane/capabilities/change_scope_budget.ts(+142)、change_quality_validation.ts(+10/-1)、effect_runtime_handlers.ts(+1)、tsconfig.control-plane.json(+1)。 - Change Quality:
loopx/capabilities/change_quality/scope.py(+89)、receipt.py(+16)、result.py(+25/-5)。 - PR Review 适配器与命令:
loopx/capabilities/pr_review_queue/scope_budget.py(+143,0Any)、core.py(+9/-1)、review_contract.py(+10/-1)、loopx/pr_review.py(+40/-3)。 - Skill 与单测:
skills/loopx-change-quality/SKILL.md(+13)、skills/loopx-pr-review/SKILL.md(+1/-1,维持 190 行)、TS 单测change_scope_budget.test.ts(+173)与change_quality_validation.test.ts(+35)、Python 单测test_change_quality.py(+155)、test_pr_review_agent_order.py(+67)、test_pr_review_result_check.py(+57)。
对主干的风险 / Risks
- 大型 Feature 兼容性与默认关闭隔离:当上游未传
scope_budget时qualifyChangeQualityValidation行为保持字节等价;当传入large_scope或elevated_scope时仅新增非阻断诊断提示,不会阻碍合理大型 Feature PR 通过change-quality、维持队列顺序或获得APPROVE。 - 新增闭合状态枚举正当性:
CHANGE_SCOPE_BUDGET_STATUSES(within_budget/net_subtraction/elevated_scope/large_scope)由唯一 TS owner 导出并通过tests/architecture/test_semantic_vocabulary_drift.py校验,不存在并行两套状态定义。 - 完整本地验证结果(exact head
b2261a535e8a3008c145b88999b56436989db3fa):./node_modules/.bin/tsc --noEmit -p tsconfig.control-plane.json: exit 0node --experimental-strip-types --test tests/control_plane_ts/change_scope_budget.test.ts tests/control_plane_ts/change_quality_validation.test.ts: 23 passed, 0 faileduv run --extra test mypy --strict --follow-imports=silent loopx/capabilities/pr_review_queue/scope_budget.py&uv run --extra test mypy: Success: no issues found in 17 source filesuv run --extra test ruff check ...: All checks passed!uv run --extra test pytest -q -n 4(6 个测试文件含test_semantic_vocabulary_drift.py与test_top_level_module_budget.py): 419 passed in 22.88s(0 skipped)uv run --extra test python examples/pr-review-command-smoke.py: pr-review-command-smoke okuv run --extra test loopx canary premerge --tier quick --from-git-diff --git-diff-base origin/main: passed (ok=true,selected=3,failures=0)loopx check --scan-path ...(18 文件): ok=True (errors=0, warnings=0)
我的整体评价 / Verdict
- Long-horizon 影响:
improved— 既在 TS 单一契约内为超大变更与多轮迭代保留了清晰的比例自省诊断信号,又彻底取消了对大型 Feature 开发的机械性阻断与队列惩罚,避免把多阶段功能人为切碎。 - User-experience 影响:
not_applicable— 仅变更控制面作用域评估、CLI JSON 诊断字段与 Skill Markdown 指引,不涉及前端渲染页面(visual_review为not_applicable)。 - 语义演进与可观测delta:
observable_semantics与decision_text_assessment均为intentional_change_validated,semantic_alignment为new_semantics_justified(candidate_decision="create_vocabulary"),均基于维护者针对大 Feature 放行的明确方向并在全量单测与 smoke 中实测通过。
实现收敛清晰、0 Any 与强类型校验全绿、419 个 Python 单测与 23 个 TS 单测全部通过且无 P0/P1/P2 问题;因触及控制面与能力运行时代码,正式合入仍需维护者授权。
English verdict: APPROVE exact head b2261a5 (author-owned COMMENTED approval review); validates change_scope_budget_assessment_v0 non-blocking large_scope and elevated_scope proportionality diagnostics while preserving fair PR queue ordering, change-quality pass, and proportionate APPROVE eligibility for cohesive large features, verified by tsc, 23 TS tests, 17-file mypy, ruff, 419 pytest tests, pr-review-command-smoke, and quick premerge canary.
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent · gpt-6.2-sol · OpenAI (runtime_reported, xhigh)
Request changes conclusion (author-owned PR; GitHub blocks formal self-review)
- [P2] 用提交父关系统计合并次数。 853 行的相同 Git 历史有三个自定义标题的双父提交。change-quality 计为 3 并给出 large_scope,pr-review 计为 0 并给出 within_budget。三个普通单父提交使用 Merge 开头标题时,pr-review 反过来报告三次合并。 当前 GitHub 源的
gh pr view --json commits只输出 OID、作者、时间和消息。请以当前 PR 提交绑定的父关系计数,数据缺失时保留未知。源码 - [P2] 用合格评审结论统计修改请求。 五条非作者的 COMMENTED 评审仅在代码块引用回退标题。pr-review 把 0 次修改请求计为 5 次,同一 1,200 行变化从 elevated_scope 升到 large_scope。 请使用 GitHub 的
CHANGES_REQUESTED状态及现有作者回退结论校验,核对作者、可见标题和一致的 verdict。源码
动机 / Motivation
PR 作者与评审者要在交付和复审时看到可靠的范围提示,以判断大改动和反复返工是否与目标相称。
基线评审和质量检查已有结论、门槛与排序。候选加入统一范围分类及比例性提醒,实际采集的合并和评审事实会改变提醒是否触发。
两个 CLI 保留原有资格和排序,PR 路径会误报和漏报触发依据。两项错误均通过实际 CLI 与 TypeScript 决策层复现。
当前范围是范围提示、比例性指导与已有门槛的边界。实际团队使用频率、注意力节省和长期维护成本待观察。
PR 端的合并次数和修改请求轮次需要使用可验证的来源。
改动思路 / Approach
两个入口都可以用共享的 TypeScript 分档规则,并维持原来的质量检查和评审资格。Git 工作树有真实父图,GitHub 的评审数据也有明确状态。保留一个 TypeScript 分类器。把 PR 适配层的数据来源收敛到提交父关系和既有结论校验,缺少证据时保留未知。 这样能让审阅者检查实际证据,同时维持对合法大改动的比例性判断。
具体改动 / Changes
评审提交 b2261a535e8a3008c145b88999b56436989db3fa,基线 513b6f168a405d5c071c79ae23fb18d2b4f5ae5d。差异涉及 18 个文件,+987/-12。运行时代码负责规则与两个入口适配,测试覆盖合格回执、排序与范围标签,两份 skill 承接原有指南。
按 docs/development/README.md 在 513b6f168a405d5c071c79ae23fb18d2b4f5ae5d 的 Scope-Fit 约定核对。
- scope-owner。两个入口调用同一共享分类器。规则的触发阈值和清理豁免在 TypeScript 集中。
- state-provenance。当前 PR 入口会从提交标题和评论正文推断事实。下面两类反例表明该条件待满足。
- existing-gates。大范围提示保留通过回执、既有排序和评审资格。原本需通过的验证检查继续起作用。
关键代码讲解
assessChangeScopeBudget接收文件、行数、提交及轮次,先处理净删减,再检查其余范围因素并给出范围等级。它只返回提示和建议。源码build_change_quality_scope用git diff --numstat收集行数,用git rev-list --merges收集真实合并,供质量路径的 scope 投影与验证消费。源码_is_merge_commit优先读父关系。现有 GitHub 详情形状缺这个字段后,使用字符串开头判断,会同时漏掉自定义合并标题并计入普通提交。源码_extract_request_changes_rounds接受正式请求状态,也搜索任何评论的正文。评审标记即使只出现在引用代码块里,也会改变结果。源码qualifyChangeQualityValidation把大范围及较高范围的诊断放入风险清单。既有必需验证仍走阻断码分支,合格的大改动可以通过。源码
对主干的风险 / Risks
在本地创建三次双父合并和 853 行净增加,以 Git 父图作为独立基准。取当前 GitHub CLI 的真实字段形状,把同一合成历史的提交信息送进 PR CLI。变更质量用真实 Git 得到三次合并,PR CLI 得到零次。另一组含三个普通单父提交的元数据使 PR CLI 得到误报。五条引用回退标题的普通评审也会使 PR CLI 发出虚假的返工提示。去掉这些引用的对照停在 elevated_scope。四个 PR fixture 的队列顺序及资格在精确 base 和 head 一致。
定向 Python 419 项、TypeScript 23 项通过。标准预合并通过 6 项直接检查及 18 项选中检查,其中目录 10 项、风险 8 项。 精确 base 和 head 的默认关闭验证都返回 disabled,head 多了 scope 诊断。无 Node 对照在两个版本均遭相同的既有运行时拒绝。对照用真实 CLI、Git 和 Effect runtime,PR 反例输入为合成元数据。托管 CI 未查询。
新增指引只用于工程评审。它会改变 reviewer 查证哪些信号,影响范围判断,也可能重复消耗注意力。请保留未能核验的计数为未知,并用真实双父图、单父对照、纯引用评论及合格的回退评审验证修复。该字段保持非阻断,评审资格和现有授权使用同一个 owner。
我的整体评价 / Verdict
REQUEST_CHANGES。 单一 TS 分类器、已有资格路径和净删减豁免均可以保留。来源适配层当前会产生假的大范围告警,也会漏掉实际的合并变动。PR 端的合并次数和修改请求轮次需要使用可验证的来源。 修复后重跑两条 CLI 对照即可判断能否交付。
本次没有改动渲染页面。 仓库经验用于选择真实入口和检查用户最终看到的输出。当前范围是范围提示、比例性指导与已有门槛的边界。实际团队使用频率、注意力节省和长期维护成本待观察。
English verdict: REQUEST_CHANGES b2261a5. PR scope guidance can miss real merges and overcount ordinary comment quotes. Bind the metrics to verified Git and review facts.
|
This pull request has merge conflicts with Choose the remote for the base repository, not an out-of-date fork. git fetch upstream
git rebase upstream/main
# Resolve each conflict, git add the resolved files, then git rebase --continue.
git push --force-with-lease origin HEADFor a same-repository clone whose Keep the DCO |
动机 / Motivation
Large feature development and iterative review refinement can legitimately accumulate broad diff surfaces (
additions >= 2500 && changed_files >= 35), multiple commits (>= 40), repeated mainline merges (>= 3), or multiple review rounds (>= 5). Blocking those branches with a mechanicalsplit_requiredhold, pushing them behind the review queue, or forbiddingverdict="proportionate"/APPROVEprevents legitimate multi-surface feature PRs from landing.At the same time, accidental shims, duplicate paths, and unrelated scope drift should still be surfaced to both author qualification and reviewers. This PR introduces a single-owner TypeScript scope-budget assessment (
change_scope_budget_assessment_v0) that surfaces non-blocking goal-proportionality diagnostics (elevated_scopeandlarge_scope) inchange-qualityandpr-reviewwhile keeping cohesive large feature branches fully eligible forchange-qualitypassing receipts, fair queue ordering,verdict="proportionate", andAPPROVE, and exemptingnet_subtractioncleanups from churn warnings.机制总览 / End-to-End Flow
flowchart TD Diff["Diff / PR metrics (changed_files, additions, deletions, commit_count, merge_commit_count, request_changes_rounds)"] --> TS["TS Control Plane: assessChangeScopeBudget (change_scope_budget_assessment_v0)"] TS -->|deletions > additions and additions <= 1500| NetSub["net_subtraction (remediation=none)"] TS -->|Bounded within limits| Ok["within_budget (remediation=none)"] TS -->|Elevated surface, rounds, commits, or merges| Elev["elevated_scope (remediation=prefer_smaller_slice)"] TS -->|Large surface, >=5 rounds, >=40 commits, or >=3 merges| Large["large_scope (remediation=verify_goal_proportionality)"] Elev -->|change-quality| CQRisk["scope_budget:elevated_scope non-blocking risk on efficiency"] Large -->|change-quality| CQLarge["scope_budget:large_scope non-blocking risk + proportionality instruction"] Large -->|pr-review scheduling| PRFair["Preserves fair queue order (no demotion or split lock)"] Large -->|pr-review result-check| PRProportional["Allows APPROVE with proportionate, or REQUEST_CHANGES if accidental bloat"]单一控制面契约与阈值 / Contract & Thresholds
loopx/control_plane/capabilities/change_scope_budget.tsexportsCHANGE_SCOPE_BUDGET_SCHEMA_VERSION = "change_scope_budget_assessment_v0",CHANGE_SCOPE_BUDGET_STATUSES,ChangeScopeBudgetStatus, andassessChangeScopeBudget, registered via"capabilities.change_scope_budget.assess"inloopx/control_plane/effect_runtime_handlers.ts.net_subtractionnonedeletions > additions && additions <= 1500(exempts cleanups from file-count & commit-churn warnings)large_scopeverify_goal_proportionalitynet_subtraction, and any of:excessive_addition_surface(additions >= 2500 && additions > deletions && changed_files >= 35),review_ping_pong_spiral(request_changes_rounds >= 5 && additions >= 1200 && additions >= deletions),excessive_commit_churn(commit_count >= 40 && additions >= 1200 && additions >= deletions),repeated_mainline_merge_commits(merge_commit_count >= 3 && additions >= 800)elevated_scopeprefer_smaller_slicenet_subtractionnorlarge_scope, and any of:elevated_addition_surface,elevated_review_rounds,elevated_commit_count,repeated_mainline_merge_commitswithin_budgetnone具体改动 / Changes
loopx/control_plane/):loopx/control_plane/capabilities/change_scope_budget.tsand registered"capabilities.change_scope_budget.assess"inloopx/control_plane/effect_runtime_handlers.ts.loopx/control_plane/capabilities/change_quality_validation.ts(qualifyChangeQualityValidation) to inspect optionalscope.scope_budget, mapping"large_scope"to diagnostic risk"scope_budget:large_scope"and"elevated_scope"to"scope_budget:elevated_scope"(never adding blocking codes), while leaving callers omittingscope_budgetunchanged.loopx/capabilities/change_quality/):scope.pyto count additions, deletions, commits, and merges againstbase_refand attachscope_budget.receipt.pyto prepend a non-blocking goal-proportionality instruction whenscope_budget.status == "large_scope".result.pyto include optionalscope_budget:prefixes in non-blocking diagnostic guardrail risk evaluation.loopx/capabilities/pr_review_queue/&loopx/pr_review.py):loopx/capabilities/pr_review_queue/scope_budget.py(zeroAny, strictmypyclean) to assess PR scale, commit/merge churn, andCHANGES_REQUESTEDrounds via"capabilities.change_scope_budget.assess".loopx/pr_review.py,core.py, andreview_contract.pyto attachscope_budget,review_plan.applicability.large_scope, and a non-blockingrisk_notesproportionality check while keeping normal queue ordering and fullAPPROVE/verdict="proportionate"eligibility for cohesive large features.skills/loopx-change-quality/SKILL.mdandskills/loopx-pr-review/SKILL.md(keeping within the<= 190-line contract).tests/control_plane_ts/change_scope_budget.test.ts,change_quality_validation.test.ts, registered intsconfig.control-plane.json) and Python unit tests (tests/capabilities/test_change_quality.py,test_pr_review_agent_order.py,test_pr_review_result_check.py).Verification
From a clean worktree rebased on
origin/main(513b6f168a):./node_modules/.bin/tsc --noEmit -p tsconfig.control-plane.json-> exit 0node --experimental-strip-types --test tests/control_plane_ts/change_scope_budget.test.ts tests/control_plane_ts/change_quality_validation.test.ts->23 passed, 0 faileduv run --extra test mypy --strict --follow-imports=silent loopx/capabilities/pr_review_queue/scope_budget.py&uv run --extra test mypy->Success: no issues found in 17 source filesuv run --extra test ruff check loopx/capabilities/change_quality/ loopx/capabilities/pr_review_queue/ loopx/pr_review.py tests/capabilities/test_change_quality.py tests/capabilities/test_pr_review_agent_order.py tests/capabilities/test_pr_review_result_check.py->All checks passed!uv run --extra test pytest -q -n 4 tests/capabilities/test_change_quality.py tests/capabilities/test_pr_review_agent_order.py tests/capabilities/test_pr_review_result_check.py tests/architecture/test_top_level_module_budget.py tests/architecture/test_semantic_vocabulary_drift.py tests/canary/test_maintainability_ratchet.py->419 passed in 22.88s(0 skipped)uv run --extra test python examples/pr-review-command-smoke.py->pr-review-command-smoke okuv run --extra test loopx canary premerge --tier quick --from-git-diff --git-diff-base origin/main->passed(ok: true,selected: 3,failures: 0)loopx check --scan-path ...across all 18 changed files ->ok: True(errors=0, warnings=0)