Show active override and temp target with remaining time on the Live Activity and in the remote command views#719
Open
bjorkert wants to merge 2 commits into
Open
Show active override and temp target with remaining time on the Live Activity and in the remote command views#719bjorkert wants to merge 2 commits into
bjorkert wants to merge 2 commits into
Conversation
…Activity and in the remote command views
…ommand buttons while an override or temp target is active
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The Live Activity gets a new row between the metric grid and the footer that shows the active override and/or temp target. The row only appears while one of them is active. When 2 hours or less remain, a live countdown ticks next to the name or target value. Longer or indefinite overrides show just the name, since a multi-day ticker gets silly. The same row appears in the expanded Dynamic Island above the updated-at line.
Since the row makes the Override grid slot redundant, it is removed from the four grid slot pickers. Stored selections from older versions render as an empty cell. It is still selectable for the CarPlay/Watch slot, which has no row.
The remote command views also show the remaining time of the active override or temp target: the Trio override and temp target views get a Time Remaining row, and the Loop override presets view shows it under the active override name. A countdown when 2 hours or less remain, otherwise a static duration like 5h 30m. Durations of a week or longer are treated as indefinite and show no remaining time at all, since Trio represents indefinite overrides and temp targets as 30 day durations.
On the remote control overview, the Overrides and Temp Target buttons get a green ring and glow while the corresponding override or temp target is active.
The end times come from the treatments parsing and travel to the extension via three new optional snapshot fields. Indefinite Loop overrides ship no end time, and the graph-edge clamp used for the chart bands is not applied to these, so long overrides count down correctly. Also clears the active override and temp target observables when treatments age out of the download window, which previously left them stale.