Skip to content

Fix graph settings not honored on the small graph#717

Merged
marionbarker merged 1 commit into
devfrom
fix/small-graph-settings
Jul 21, 2026
Merged

Fix graph settings not honored on the small graph#717
marionbarker merged 1 commit into
devfrom
fix/small-graph-settings

Conversation

@bjorkert

Copy link
Copy Markdown
Member

The Swift Charts migration (#704) lost some of the settings that control
what the small graph shows.

  • "Treatments on Small Graph" was ignored. Treatments, basal, overrides
    and temp targets were always drawn, and flipping the toggle didn't
    refresh the chart.
  • Midnight lines no longer showed on the small graph.
  • With prediction style "Lines" the ZT/IOB/COB/UAM lines were missing
    from the small graph, so Trio users had no prediction there.
  • Yesterday's BG was drawn on the small graph. The old chart only drew
    it on the main graph.

This restores the old behavior. The prediction cone stays visible on the
small graph. Also added the missing chart refresh to the "Show Carb/Bolus
Values" and "Show Carb Absorption" toggles so they apply right away
instead of on the next reading.

Tested in simulator:

  • Toggling "Treatments on Small Graph" off hides boluses, carbs, SMBs,
    basal, overrides and temp targets on the small graph only, and they
    come back when toggled on again, without restarting the app.
  • Midnight lines show on both graphs when enabled.
  • Yesterday's BG shows on the main graph only.
  • Cone style shows the cone and Lines style shows all four prediction
    lines on both graphs.
  • Built for device and simulator via the workspace.

@marionbarker

Copy link
Copy Markdown
Collaborator

Test

✅ Trio URL (on SE 3rd gen running iOS 26)
✅ Loop URL (on SE 2nd gen running iOS 18)
✅ Loop URL (on Mac Catalyst)

@marionbarker marionbarker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve by code review and test.

@marionbarker
marionbarker merged commit b06efbf into dev Jul 21, 2026
1 check passed
@marionbarker
marionbarker deleted the fix/small-graph-settings branch July 21, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants