Fix graph settings not honored on the small graph#717
Merged
Conversation
Collaborator
Test✅ Trio URL (on SE 3rd gen running iOS 26) |
marionbarker
approved these changes
Jul 21, 2026
marionbarker
left a comment
Collaborator
There was a problem hiding this comment.
Approve by code review and test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Swift Charts migration (#704) lost some of the settings that control
what the small graph shows.
and temp targets were always drawn, and flipping the toggle didn't
refresh the chart.
from the small graph, so Trio users had no prediction there.
it on the main graph.
This restores the old behavior. The prediction cone stays visible on the
small graph. Also added the missing chart refresh to the "Show Carb/Bolus
Values" and "Show Carb Absorption" toggles so they apply right away
instead of on the next reading.
Tested in simulator:
basal, overrides and temp targets on the small graph only, and they
come back when toggled on again, without restarting the app.
lines on both graphs.