Skip to content

feat(proto): add engine_error to restore status responses #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
derekbit merged 2 commits into from
Sep 12, 2026
Merged

feat(proto): add engine_error to restore status responses #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ad27ac
feat(proto): add engine_error to restore status responses
c3y1huang Sep 3, 2026
ba282bd
chore: regenerate code
c3y1huang Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
120 changes: 60 additions & 60 deletions generated-py/imrpc/proxy_pb2.py
View file
Open in desktop

Large diffs are not rendered by default.

100 changes: 50 additions & 50 deletions generated-py/spdkrpc/spdk_pb2.py
View file
Open in desktop

Large diffs are not rendered by default.

936 changes: 474 additions & 462 deletions pkg/generated/imrpc/proxy.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

1,711 changes: 862 additions & 849 deletions pkg/generated/spdkrpc/spdk.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions protobuf/imrpc/proxy.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,9 @@ message EngineBackupRestoreProxyResponse {

message EngineBackupRestoreStatusProxyResponse {
map<string, EngineBackupRestoreStatus> status = 1;
// Engine-level restore error. Set only by the v2 data engine;
// the v1 path leaves it empty. Empty means no error.
string engine_error = 2;
}

message EngineBackupRestoreStatus {
Expand Down
4 changes: 4 additions & 0 deletions protobuf/spdkrpc/spdk.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,6 +753,10 @@ message ReplicaRestoreStatusResponse {

message RestoreStatusResponse {
map<string, ReplicaRestoreStatusResponse> status = 1;
// Engine-level restore error not attributed to any replica.
// Keep it on this wrapper, not on the per-replica message.
// Empty means no error.
string engine_error = 2;
}

// DataLayoutType is the top-level storage topology of an engine.
Expand Down