Repository navigation
feat(proto): add TransportType (TCP/RDMA) to spdkrpc + imrpc - #121
Open
abonillabeeche wants to merge 1 commit into
Open
abonillabeeche wants to merge 1 commit into
abonillabeeche wants to merge 1 commit into
Conversation
This was referenced Aug 20, 2026
Open
abonillabeeche
force-pushed
the
rdma-transport
branch
from
August 20, 2026 05:18
1fbbe06 to
bd37823
Compare
abonillabeeche
changed the title
abonillabeeche
added a commit
to abonillabeeche/longhorn-spdk-engine
that referenced
this pull request
Aug 22, 2026
Rename the struct field to TransportType on Engine and Replica and the client-method params to transportType, and consume the renamed spdkrpc.TransportType enum. No behavior change. Ref: longhorn/longhorn#13796 Co-Authored-By: Claude Opus 4.8 <[email protected]> Signed-off-by: Alejandro Bonilla <[email protected]>
abonillabeeche
added a commit
to abonillabeeche/longhorn-instance-manager
that referenced
this pull request
Aug 22, 2026
Consume the renamed imrpc/spdkrpc TransportType enum and rename the IM-side field/params and the IM->SPDK conversion helper accordingly. No behavior change. Ref: longhorn/longhorn#13796 Co-Authored-By: Claude Opus 4.8 <[email protected]> Signed-off-by: Alejandro Bonilla <[email protected]>
abonillabeeche
added a commit
to abonillabeeche/longhorn-manager
that referenced
this pull request
Aug 22, 2026
The v2 proto enum was renamed DataEngineTransport -> TransportType in longhorn/types#121. Adapt at the instance-manager client boundary: the generated imrpc type is now imrpc.TransportType and the IM client request field is TransportType. longhorn-manager keeps its own DataEngineTransport type and VolumeSpec field name (this repo's convention), converting to the renamed enum in toIMRPCDataEngineTransport and setting the renamed IM client field. No behavior change. Ref: longhorn/longhorn#13796 Co-Authored-By: Claude Opus 4.8 <[email protected]> Signed-off-by: Alejandro Bonilla <[email protected]>
abonillabeeche
changed the title
Add a TransportType enum (TCP=0 default, RDMA=1) selecting the NVMe-oF transport of the internal engine<->replica data fabric of a v2 volume, and thread a transport_type field through: - spdkrpc.EngineCreateRequest (field 15) and ReplicaCreateRequest (field 7) - imrpc.SpdkInstanceSpec (field 17) Mirrors the DataLayoutType precedent. Unset (0) == TCP preserves the behavior of all existing volumes and older peers. Ref: longhorn/longhorn#13796 Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Alejandro Bonilla <[email protected]>
abonillabeeche
force-pushed
the
rdma-transport
branch
from
October 2, 2026 00:04
f50b24e to
05d5fe5
Compare
abonillabeeche
marked this pull request as ready for review
October 2, 2026 00:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue longhorn/longhorn#13796
Adds a
TransportTypeenum (TRANSPORT_TYPE_TCP = 0,TRANSPORT_TYPE_RDMA = 1) to imrpc and spdkrpc, and atransport_typefield on:imrpc.SpdkInstanceSpec(17)spdkrpc.EngineCreateRequest(15) andspdkrpc.ReplicaCreateRequest(7)spdkrpc.Replica(18), so an engine can check that a replica is exposed over the same transport before connecting to it (feat(spdk): thread NVMe-oF transport type through engine/replica create longhorn-spdk-engine#654)Regenerated Go and Python bindings are included (
make generate_grpc). TCP is the zero value, so older peers keep today's behavior.Merge order: #121 -> longhorn/go-spdk-helper#308 -> longhorn/longhorn-spdk-engine#654 -> longhorn/longhorn-instance-manager#1616 -> longhorn/longhorn-manager#5107. longhorn/dep-versions#216 (build SPDK with RDMA) and the chart change longhorn/longhorn#13797 are independent. Each downstream PR only needs a go.mod/vendor bump once the one above it is merged; the branches are rebased on current master/main.