Repository navigation
ci: release automatically from conventional commits - #10
Conversation
szymeo
left a comment
There was a problem hiding this comment.
Lead review: logdash moved from services to domains, so the smoke test must use the domain model instead of a project.
LOGDASH_API_KEYbecomes the ingest key of one shared domain, "SDK smoke tests" (its Settings page, "Ingest key": one write-only key for every app on the domain). The owner adds it, replacing this repo's old per-service key.- Send with the SDK's
appoption set todotnet-sdk, so each SDK shows up as its own app on that domain. LOGDASH_PERSONAL_API_KEYis a read-only key (Logs read, Metrics read) restricted to that domain.GET https://api.logdash.io/personal-api-keys/whoamireturnsaccess: { kind: "clusters", ids: [domainId] }. Fail with a clear message unless the kind isclustersand there is an id.- Read logs from
GET /clusters/{domainId}/logs?apps=dotnet-sdk(narrowed to this run's seed) and metrics fromGET /clusters/{domainId}/metrics(each entry hasapp,name,value: match onappandname), both with the same bearer. Drop/projects/{id}/.... - Never print an API key, not even one CI masks.
Check paths, query params and response shapes against logdash-io/logdash.io: apps/backend/src/log/core/log-core.controller.ts (readClusterLogs, ReadClusterLogsQuery in log/core/dto/cluster-logs.query.ts) and apps/backend/src/metric/core/metric-core.controller.ts (readClusterMetrics). The check program needs the app option, so it runs against the version this PR releases; before that, a manual run on this branch is not expected to pass.
…tional Commits, fix its…
szymeo
left a comment
There was a problem hiding this comment.
Lead review: two blocking, two minor. Release computes 0.1.0; pack produces only Logdash.0.1.0.nupkg; endpoints and shapes match the backend.
- BLOCKING
ci.yml~24:dotnet test Logdash.Testsfails in PR CI. There is noglobal.json, so the runner's preinstalled .NET 10 SDK runs instead of the 9.0 SDK setup-dotnet adds, and Microsoft.Testing.Platform rejects VSTest on SDK 10. Add a rootglobal.json:{"sdk":{"version":"9.0.100","rollForward":"latestFeature"}}(checked in Docker with SDKs 9.0.319 and 10.0.402: it picks 9.0.319 and all 24 tests pass). Make the PR checks green. - MINOR permissions: the repo default token is write and no workflow sets top-level permissions. Add
permissions: {contents: read}abovejobs:inci.ymlandcheck-deployed-package.yml(jobs that need more keep their own block), andpermissions: {}inpr-title.yml. - MINOR
ci.yml~64, make the release re-runnable: ifgh release createfails after a good push, a rerun gets 409 on the push and never tags. Append${{ github.run_attempt != '1' && '--skip-duplicate' || '' }}to the push, so a rerun skips the duplicate and tags.
NUGET_USER and LOGDASH_PERSONAL_API_KEY come from the owner; nothing to do for them here.
szymeo
left a comment
There was a problem hiding this comment.
One more small one: scripts/version.ts line ~4 still names tony's Info.plist. Say that the csproj VersionPrefix version is the placeholder CI overwrites before packaging.
…tional Commits, fix its…
…tional Commits, fix its…
Summary
ci: release automatically from conventional commits
Publish
malini/01JDF5B3C729DC4419399DFABAagainstmain..github/workflows/approval.ymlValidation