Skip to content

ci: release automatically from conventional commits - #10

Merged
szymeo merged 4 commits into
mainfrom
malini/01JDF5B3C729DC4419399DFABA
Oct 25, 2026
Merged

szymeo merged 4 commits into
mainfrom
malini/01JDF5B3C729DC4419399DFABA

Conversation

@szymeo

@szymeo szymeo commented Oct 24, 2026 •

Copy link
Copy Markdown
Member

Summary

ci: release automatically from conventional commits

Publish malini/01JDF5B3C729DC4419399DFABA against main.

  • .github/workflows/approval.yml

Validation

  • Passed - Validation: node --test scripts/*.test.ts
  • Passed - Validation: node --test 'scripts/*.test.ts'

@szymeo szymeo left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lead review: logdash moved from services to domains, so the smoke test must use the domain model instead of a project.

  • LOGDASH_API_KEY becomes the ingest key of one shared domain, "SDK smoke tests" (its Settings page, "Ingest key": one write-only key for every app on the domain). The owner adds it, replacing this repo's old per-service key.
  • Send with the SDK's app option set to dotnet-sdk, so each SDK shows up as its own app on that domain.
  • LOGDASH_PERSONAL_API_KEY is a read-only key (Logs read, Metrics read) restricted to that domain. GET https://api.logdash.io/personal-api-keys/whoami returns access: { kind: "clusters", ids: [domainId] }. Fail with a clear message unless the kind is clusters and there is an id.
  • Read logs from GET /clusters/{domainId}/logs?apps=dotnet-sdk (narrowed to this run's seed) and metrics from GET /clusters/{domainId}/metrics (each entry has app, name, value: match on app and name), both with the same bearer. Drop /projects/{id}/....
  • Never print an API key, not even one CI masks.

Check paths, query params and response shapes against logdash-io/logdash.io: apps/backend/src/log/core/log-core.controller.ts (readClusterLogs, ReadClusterLogsQuery in log/core/dto/cluster-logs.query.ts) and apps/backend/src/metric/core/metric-core.controller.ts (readClusterMetrics). The check program needs the app option, so it runs against the version this PR releases; before that, a manual run on this branch is not expected to pass.

@szymeo szymeo left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lead review: two blocking, two minor. Release computes 0.1.0; pack produces only Logdash.0.1.0.nupkg; endpoints and shapes match the backend.

  • BLOCKING ci.yml ~24: dotnet test Logdash.Tests fails in PR CI. There is no global.json, so the runner's preinstalled .NET 10 SDK runs instead of the 9.0 SDK setup-dotnet adds, and Microsoft.Testing.Platform rejects VSTest on SDK 10. Add a root global.json: {"sdk":{"version":"9.0.100","rollForward":"latestFeature"}} (checked in Docker with SDKs 9.0.319 and 10.0.402: it picks 9.0.319 and all 24 tests pass). Make the PR checks green.
  • MINOR permissions: the repo default token is write and no workflow sets top-level permissions. Add permissions: {contents: read} above jobs: in ci.yml and check-deployed-package.yml (jobs that need more keep their own block), and permissions: {} in pr-title.yml.
  • MINOR ci.yml ~64, make the release re-runnable: if gh release create fails after a good push, a rerun gets 409 on the push and never tags. Append ${{ github.run_attempt != '1' && '--skip-duplicate' || '' }} to the push, so a rerun skips the duplicate and tags.

NUGET_USER and LOGDASH_PERSONAL_API_KEY come from the owner; nothing to do for them here.

@szymeo szymeo left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more small one: scripts/version.ts line ~4 still names tony's Info.plist. Say that the csproj VersionPrefix version is the placeholder CI overwrites before packaging.

Comment thread .github/workflows/pr-title.yml
@szymeo
szymeo marked this pull request as ready for review October 25, 2026 12:43
@szymeo
szymeo merged commit f273dfb into main Oct 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant