fix(hlpr): pass the end keyword of lob_print to print - #23
Merged
Merged
Conversation
lob_print popped end before printing, so lob_print(path, "x", end="") still printed a newline. Leave it in the print kwargs; the log file side never used it. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
MrKevinWeiss
commented
Sep 30, 2026
MrKevinWeiss
left a comment
MrKevinWeiss
left a comment
Collaborator
Author
There was a problem hiding this comment.
Wouldn't this be an unexpect kwarg for logging and we get an error?
Collaborator
Author
|
No: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lob_printpoppedendbefore calling_print_color, despite the comment saying it is "consumed by print", solob_print(path, "x", end="")still printed"x\n". It now stays in the kwargs that reachprint; the log file side never used it.New test (plain and colored) fails on master.
🤖 Generated with Claude Code