fix(hlpr): parse hex files without an extended address record - #22
Merged
Merged
Conversation
extract_identifier_from_hexfile only set extended_address on a type 04 record, so a valid Intel HEX file whose data records come first raised UnboundLocalError, which also escaped fw_id_from_fw_file's ValueError contract. Start at 0, as Intel HEX defines. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extract_identifier_from_hexfileonly assignedextended_addresson a type 04 record. A valid Intel HEX file whose data records come before any 04 record (small images, tools that omit the default:020000040000FA) crashed withUnboundLocalError, which also escapedfw_id_from_fw_file'sValueErrorcontract. The upper address bits now start at 0, as Intel HEX defines.New test strips the 04 record from an existing fixture; it fails on master with the
UnboundLocalError.🤖 Generated with Claude Code