fix: parse -dirty/-unknown suffix in firmware identifiers - #19
Merged
Merged
Conversation
MrKevinWeiss
added a commit
that referenced
this pull request
Aug 26, 2026
PR #19 regex fix lets FirmwareID parse -dirty/-unknown after the git describe suffix. Add regression tests using the real id string found in the app-nrf91-origin 0.14.0-rc.1-89-g04cac05 hex plus dirty variants. Ignore Lobaro variant name 'lonly' in codespell. Co-authored-by: Copilot <[email protected]>
FirmwareID regex rejected version strings where the git describe suffix is followed by -dirty or -unknown, e.g. a locally built '0.14.0-rc.1-89-g04cac05-dirty'. Allow the suffixes after the describe part so FirmwareVersion can flag them. Add regression tests including the real id string from the app-nrf91-origin 0.14.0-rc.1-89-g04cac05 hex. Ignore Lobaro variant name 'lonly' in codespell. Co-authored-by: Copilot <[email protected]>
MrKevinWeiss
force-pushed
the
fix/firmware-info
branch
from
August 26, 2026 11:05
0e1bd3a to
903b0ad
Compare
MrKevinWeiss
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FirmwareIDrejected version strings where the git describe suffix is followed by-dirtyor-unknown, e.g. a locally built firmware reporting:This broke flashing of dirty firmware builds (seen with lob-cord).
Fix
Allow optional
-dirty/-unknownsuffixes after the git describe part in both identifier regexes.FirmwareVersionalready parsed these and sets thedirty/unknownflags correctly.Tests
app-nrf91-origin+0.14.0-rc.1-89-g04cac05+hw4.lonly~full.hexbinary-dirtyand-dirty-unknownafter the commit hash-dirtytox -e lintand fulltoxpass (65 tests)Also ignores the Lobaro variant name
lonlyin codespell.Co-authored-by: Copilot [email protected]