Skip to content

Base sea pearl task - #2

Open
Ignose wants to merge 3 commits into
mainfrom
sea-pearls
Open

Ignose wants to merge 3 commits into
mainfrom
sea-pearls

Conversation

@Ignose

@Ignose Ignose commented Oct 13, 2026

Copy link
Copy Markdown

No description provided.

}

const SEA_PEARL_QUESTS: QuesoQuest = {
name: "Farm Sea Pearls",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will end up as

Farm Sea Pearls/Sea Pearl Deepest

which feels a bit verbose. I would just make this "Sea Pearls" and drop name from SEA_PEARL_ZONES and just use the location's name instead

Comment thread src/quests/evergreen/seaPearl.ts Outdated
name: "Sea Pearl Mine",
prop: "_unblemishedPearlAnemoneMine",
location: $location`Anemone Mine`,
modifier: "spooky res",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typed modifier you could use here

$modifier`Spooky Resistance`

Comment thread src/quests/evergreen/seaPearl.ts Outdated
import { QuesoQuest, QuesoStrategy } from "../../engine";
import Macro from "../../macro";

tryFindFreeKill({});

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this at the top level scope?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to try and figure out how to make use of it, but failed. I removed it.

Comment thread src/quests/evergreen/seaPearl.ts Outdated
return (
get("isMerkinGladiatorChampion") &&
(mallPrice($item`unblemished pearl`) / 10 >= get("valueOfAdventure") ||
myInebriety() > inebrietyLimit() + 1)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a sober() function which available will already check if you set sobriety on the task

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong anyway, fixing it.

Comment thread src/quests/evergreen/seaPearl.ts Resolved
Comment thread src/quests/evergreen/seaPearl.ts Resolved
Comment thread src/quests/evergreen/seaPearl.ts Outdated
Comment on lines +151 to +152
clear: "all" as const,
tracking: "Sea Pearl",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do these two properties do?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing outside of my wrapper, removing.

Comment thread src/quests/evergreen/seaPearl.ts Resolved
Comment thread src/quests/evergreen/seaPearl.ts Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants