Skip to content

fix(english): lightnovelworld empty chapter (coupling with my APP PR) #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rajarsheechatterjee merged 1 commit into from
Aug 16, 2026
Merged

fix(english): lightnovelworld empty chapter (coupling with my APP PR) #2417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 34 additions & 17 deletions plugins/english/lightnovelworld.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export class LightNovelWorldPlugin implements Plugin.PluginBase {
name = "LightNovelWorld";
icon = "src/en/lightnovelworld/icon.png";
site = "https://lightnovelworld.org/";
version = "1.0.1";
version = "1.0.2";

filters = {
sort: {
Expand Down Expand Up @@ -199,6 +199,11 @@ export class LightNovelWorldPlugin implements Plugin.PluginBase {
const apiBase = `${this.site}api/novel/${slug}/chapters/?limit=${LIMIT}`;

const firstRes = await fetchApi(`${apiBase}&offset=0`);
if (!firstRes.ok) {
throw new Error(
`Failed to fetch chapters (HTTP ${firstRes.status})`,
);
}
const firstJson = (await firstRes.json()) as {
chapters: { number: number; title: string }[];
total_chapters: number;
Expand All @@ -212,17 +217,23 @@ export class LightNovelWorldPlugin implements Plugin.PluginBase {

const remainingResults = await Promise.all(
offsets.map(async (offset) => {
try {
const res = await fetchApi(`${apiBase}&offset=${offset}`);
const json = (await res.json()) as { chapters: { number: number; title: string }[] };
return json.chapters || [];
} catch {
return [];
const res = await fetchApi(`${apiBase}&offset=${offset}`);
if (!res.ok) {
throw new Error(
`Failed to fetch chapters page ${offset} (HTTP ${res.status})`,
);
}
const json = (await res.json()) as {
chapters: { number: number; title: string }[];
};
return json.chapters || [];
})
);

const rawChapters = [...(firstJson.chapters || []), ...remainingResults.flat()];
const rawChapters = [
...(firstJson.chapters || []),
...remainingResults.flat(),
];

return rawChapters
.map((ch) => ({
Expand Down Expand Up @@ -255,11 +266,7 @@ export class LightNovelWorldPlugin implements Plugin.PluginBase {
let chapters: Plugin.ChapterItem[] = [];

if (slug) {
try {
chapters = await this.fetchAllChapters(slug);
} catch {
chapters = [];
}
chapters = await this.fetchAllChapters(slug);
}

return {
Expand All @@ -275,19 +282,29 @@ export class LightNovelWorldPlugin implements Plugin.PluginBase {
}

async parseChapter(chapterPath: string): Promise<string> {
const html = await fetchText(`${this.site}${chapterPath}`);
const url = `${this.site}${chapterPath}`;
const res = await fetchApi(url);
if (!res.ok) {
throw new Error(`Could not load chapter (HTTP ${res.status})`);
}
const html = await res.text();
const $ = loadCheerio(html);

const container = $('#chapterText');
if (!container.length) {
return '<p>No content found.</p>';
throw new Error('Could not load chapter');
}

container.find('script, style, ins, iframe, .ads, .ad-container, .watermark').remove();
container
.find('script, style, ins, iframe, .ads, .ad-container, .watermark')
.remove();
container.find('[style]').removeAttr('style');

const content = container.html()?.trim() || '';
return content || '<p>No content found.</p>';
if (!content) {
throw new Error('Could not load chapter');
}
return content;
}

async searchNovels(
Expand Down
Loading