Skip to content

fix(deps): update dependency textlint-rule-apostrophe to v3 #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
literat merged 4 commits into from
Sep 11, 2026
Merged

fix(deps): update dependency textlint-rule-apostrophe to v3 #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51d77eb
fix(deps): update dependency textlint-rule-apostrophe to v3
renovate[bot] Sep 11, 2026
d788ec5
style(repo): resolve exports-only packages via typescript resolver
literat Sep 11, 2026
8989af7
style(eslint-config-typescript): drop stale import/no-unresolved disa…
literat Sep 11, 2026
a92ed99
style(textlint): drop stale import/no-unresolved disable
literat Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,19 @@ export default [
// Disabled because off node do not resolve
'import/extensions': 'off',
},

settings: {
// The `node` resolver (via the `resolve` package) doesn't understand the
// package.json `exports` field, so exports-only ESM packages fail
// `import/no-unresolved`. Fall back to the typescript resolver
// (enhanced-resolve), which does support `exports`, for plain JS too.
'import/resolver': {
node: {
extensions: ['.mjs', '.cjs', '.js', '.json', '.node'],
},
typescript: {},
},
},
},
prettierConfig,
];
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
"eslint": "9.39.4",
"eslint-config-prettier": "9.1.2",
"eslint-import-resolver-node": "0.3.9",
"eslint-import-resolver-typescript": "3.10.1",
"eslint-plugin-jest-formatting": "3.1.0",
"eslint-plugin-prettier": "5.5.5",
"husky": "9.1.7",
Expand Down
2 changes: 0 additions & 2 deletions packages/eslint-config-typescript/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import base from '@alma-oss/eslint-config-base';
import settings from '@alma-oss/eslint-config-base/settings';
// eslint-disable-next-line import/no-unresolved
import tsEslint from 'typescript-eslint';
// eslint-disable-next-line import/no-unresolved
import tsParser from '@typescript-eslint/parser';
import globs from '@alma-oss/eslint-config-base/globs';

Expand Down
1 change: 0 additions & 1 deletion packages/eslint-config-typescript/react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import reactConfig from '@alma-oss/eslint-config-react';
import globs from '@alma-oss/eslint-config-base/globs';
// eslint-disable-next-line import/no-unresolved
import parser from '@typescript-eslint/parser';

export default [
Expand Down
2 changes: 1 addition & 1 deletion packages/textlint-rule-preset-alma/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"dependencies": {
"textlint": "^15.0.0",
"textlint-filter-rule-comments": "^1.2.2",
"textlint-rule-apostrophe": "^2.0.0",
"textlint-rule-apostrophe": "^3.0.0",
"textlint-rule-common-misspellings": "^1.0.1",
"textlint-rule-stop-words": "^3.0.0",
"textlint-rule-terminology": "^5.0.0",
Expand Down
1 change: 0 additions & 1 deletion packages/textlint-rule-preset-alma/rules/terminology.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// eslint-disable-next-line import/no-unresolved -- v5 only declares `exports`, which [email protected] can't read; Node resolves it fine at runtime.
import textlintRuleTerminology from 'textlint-rule-terminology';

const defaultOptions = {
Expand Down
13 changes: 7 additions & 6 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ __metadata:
"@textlint/textlint-plugin-text": "npm:^15.0.0"
textlint: "npm:^15.0.0"
textlint-filter-rule-comments: "npm:^1.2.2"
textlint-rule-apostrophe: "npm:^2.0.0"
textlint-rule-apostrophe: "npm:^3.0.0"
textlint-rule-common-misspellings: "npm:^1.0.1"
textlint-rule-stop-words: "npm:^3.0.0"
textlint-rule-terminology: "npm:^5.0.0"
Expand Down Expand Up @@ -5369,6 +5369,7 @@ __metadata:
eslint: "npm:9.39.4"
eslint-config-prettier: "npm:9.1.2"
eslint-import-resolver-node: "npm:0.3.9"
eslint-import-resolver-typescript: "npm:3.10.1"
eslint-plugin-jest-formatting: "npm:3.1.0"
eslint-plugin-prettier: "npm:5.5.5"
husky: "npm:9.1.7"
Expand Down Expand Up @@ -6478,7 +6479,7 @@ __metadata:
languageName: node
linkType: hard

"eslint-import-resolver-typescript@npm:^3.2.7":
"eslint-import-resolver-typescript@npm:3.10.1, eslint-import-resolver-typescript@npm:^3.2.7":
version: 3.10.1
resolution: "eslint-import-resolver-typescript@npm:3.10.1"
dependencies:
Expand Down Expand Up @@ -14766,10 +14767,10 @@ __metadata:
languageName: node
linkType: hard

"textlint-rule-apostrophe@npm:^2.0.0":
version: 2.0.0
resolution: "textlint-rule-apostrophe@npm:2.0.0"
checksum: 10/e975b163bafdf35ed6f72e91ad3e05b6952ca5f7db618c0a6165769b6ee694f6631b6cdb4ea882ddb62a35b4fa56b525f281edd68753f741a7ab1b3196c82322
"textlint-rule-apostrophe@npm:^3.0.0":
version: 3.0.0
resolution: "textlint-rule-apostrophe@npm:3.0.0"
checksum: 10/75780336942a0a6397bdfd0bfc04b0796560d8478e9f9219d91d3b2ce517246bd6bc18c1d157af2b674586007d389825c4b2590a415c656476f963af3f2d1284
languageName: node
linkType: hard

Expand Down