Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f3c86cdb36
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| try { | ||
| const repo = path.join(dir, 'repo'); | ||
| const wt = path.join(dir, 'repo-feature-x'); | ||
| const git = (...a) => execFileSync('git', ['-c', 'user.name=t', '-c', '[email protected]', ...a], { cwd: repo, stdio: 'pipe' }); |
There was a problem hiding this comment.
When the developer has global Git settings such as commit.gpgSign=true, this helper inherits them and the empty commit fails before the assertions run; a global hooks path or init template can similarly change the fixture. This is reproducible by running the test with a temporary HOME containing a .gitconfig that enables signing. Disable signing and hooks explicitly, or give these Git commands an isolated global/system config, so the test behaves the same on developer machines and clean CI.
Useful? React with 👍 / 👎.
This branch has not been deployed
1 participant
Summary
Test-only: an agentflow dispatch record whose clone path is a herdr worktree (a linked
git worktree, not agentflow's default external-runner temp clone) matches the worker sessions that ran in that worktree.test/agentflow-herdr-worktree.test.js(synthetic data; one case creates a real linked worktree in a temp dir, reads its dispatch record from disk withclone.root, and reaches it through a symlinked cwd).attributeWorkersalready treats any path a dispatch record names as a clone (except the reported checkout root), so herdr worktree paths match.Verification