Repository navigation
test(agentflow): retarget compatibility to agentflow v8.4.15 - #700
Conversation
Bump the upstream compatibility target from 8.4.14 to v8.4.15 (80fcd7f) in the fixture generator, docs and the replyDigest golden test. notebook-write.js, round-linter.js and local-time.js are unchanged upstream, so server/agentflow/notebook.js only updates its version reference. Add synthetic v8.4.15 fixtures and tests: a Claude host that captures later owner input with manual append-input (and degrades to window attribution without it), and compaction that keeps the latest completed Ask live. Document the Claude manual append-input requirement in agentflow-report.md. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33350173de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const { spawn, spawnSync, fork, execFileSync } = require('node:child_process'); | ||
|
|
||
| const UPSTREAM_COMMIT = 'd0a6dd0a00d2d0914c900a0a5851764b32b50fb1'; // agentflow 8.4.14 | ||
| const UPSTREAM_COMMIT = '80fcd7f81e21b2c1cbcaeda53a40a0ede8fcab1d'; // agentflow 8.4.15 |
There was a problem hiding this comment.
When the fixture generator is run against the newly pinned v8.4.15 checkout, it writes 80fcd7f into generated/manifest.json, but test/agentflow-generated.e2e.test.js:57 still requires d0a6dd0; the committed manifest also remains at that old hash. Consequently, following the documented regeneration command immediately makes the unit suite fail, while the real-runner fixture continues covering v8.4.14 rather than the newly declared compatibility target. Regenerate the fixture and update its guard, or retain the historical pin here.
Useful? React with 👍 / 👎.
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "command": "node notebook-write.js append-input --notebook .agentflow/devlog.md --host claude --session S2 --input-stdin", | |||
There was a problem hiding this comment.
In this fixture the startup submission belongs to S1, but the purported follow-up capture passes --session S2. Agentflow v8.4.15 requires later Claude messages to be saved using the startup session_id (upstream Shared notebooks documentation); moreover, the test never executes this command and only uses its text as generic notebook evidence. The passing expectedCaptured branch therefore cannot demonstrate the valid upstream workflow it claims to model; use the startup session consistently and model the later submission in that same Claude session.
Useful? React with 👍 / 👎.
Summary
Retarget ccxray's agentflow compatibility from upstream 8.4.14 to v8.4.15 (
80fcd7f).UPSTREAM_COMMIT, docs and thereplyDigestgolden-test label now name v8.4.15.server/agentflow/notebook.js: comment-only version bump. Justified: upstreamnotebook-write.js,round-linter.jsandlocal-time.js(the files its patterns mirror) are unchanged between v8.4.14 and v8.4.15 (checked against the upstream compare), so the parsing patterns still match exactly.test/agentflow-v8415.test.js,test/fixtures/agentflow/v8.4.15/):append-input, and degrades towindowattribution when it does not;docs/agentflow-report.md: Claude hosts must runappend-inputmanually since v8.4.15, otherwise attribution degrades towindow.Verification