Skip to content

fix(release): one draft release per tag, published by the notes job #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lippdev merged 1 commit into from
Oct 27, 2026
Merged

fix(release): one draft release per tag, published by the notes job #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,12 @@ jobs:
git config user.email "[email protected]"
git tag -a "v${{ needs.decide.outputs.version }}" -m "JoyChromium ${{ needs.decide.outputs.version }}"
git push origin "v${{ needs.decide.outputs.version }}"
# electron-builder uploads each architecture in parallel; with no release to find, each upload creates its own and
# the tag ends up with two. This draft is the one release they all upload to; `notes` publishes it.
- name: Create the draft release
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: gh release create "v${{ needs.decide.outputs.version }}" --draft --verify-tag --title "${{ needs.decide.outputs.version }}" --notes ""

build:
needs: [decide, tag]
Expand Down Expand Up @@ -145,7 +151,7 @@ jobs:
| node app/scripts/release-notes.mjs "${previous:-}" "${VERSION#v}" > notes.md
# Alpha and other prerelease builds stay out of the installed app's latest update channel.
if [ "$PRERELEASE" = "true" ]; then
gh release edit "$VERSION" --notes-file notes.md --prerelease --latest=false
gh release edit "$VERSION" --notes-file notes.md --draft=false --prerelease --latest=false
else
gh release edit "$VERSION" --notes-file notes.md
gh release edit "$VERSION" --notes-file notes.md --draft=false
fi
Loading