Repository navigation
feat: show the update notice's highlight in Portuguese, and in any language with a changelog - #158
Merged
Merged
Conversation
…nguage with a changelog Since 1.5.0-beta.6 the release body is English only, so everyone, Portuguese users included, read the update notice in English. The release workflow now appends one hidden <!-- summary <code>: ... --> line per translated changelog (CHANGELOG.md for pt-BR, any CHANGELOG.<code>.md for another language), after the notes so older clients still show the English item. ReleaseNotes.FirstLine prefers the summary for the interface language and strips Markdown links. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes This review covers localized update-highlight generation and display, including release-note parsing and changelog entries.
- Release summaries The release workflow appends hidden summaries for Portuguese and optional translated changelogs while preserving the visible release body and the English fallback.
- Update notice parsing
ReleaseNotes.FirstLineselects a summary matching the exact interface language, cleans basic Markdown formatting, and falls back to the existing notes parser when absent or invalid. - Compatibility and coverage Summaries remain after the visible notes for older clients; tests cover language selection, CRLF, fallback, and malformed summaries.
gpt-6-luna | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
The update notice shows the first item of the release notes. Since 1.5.0-beta.6 the release body is English only (the Portuguese changelog is linked, not pasted), so every user, Portuguese ones included, reads "What's new" in English. Spanish, German, French and Russian users too, with no way to change that short of rewriting the release format.
What
release.yml: after the notes, the body gets one hidden line per translated changelog:<!-- summary pt-BR: Minimizar para a bandeja: … (#150) -->CHANGELOG.md(already required).CHANGELOG.<code>.md(e.g. a futureCHANGELOG.es-ES.md) is picked up on its own; if it lacks the version's section it is skipped with a log line, never failing the release.-->inside an item is removed so it can't close the comment early.ReleaseNotes.FirstLine: uses the summary for the exact interface language when there is one, otherwise the current behavior (the English first item). Markdown links now show as their text (u/Skinner99instead of[u/Skinner99](https://…)) in both paths.Compatibility: the summaries sit at the very end of the body, after the "Notas em português" line. Clients up to 1.6.x show the first line they find, so they keep showing the English item. Covered by
Summaries_StayAfterTheNotesForOlderClients.The effect shows from the first release published after this, read by clients that include it (so: 1.7.0 users updating to 1.7.x).
Testing
dotnet test: 415 passed (4 new: summary wins for its language, CRLF, other languages fall back to English, empty or unclosed summary falls back, summaries stay after the notes).VERSION=1.6.2against the real changelogs: the body is identical up to the Portuguese link, then gets the pt-BR summary. With a fakeCHANGELOG.es-ES.md(has the section, contains-->) andCHANGELOG.fr-FR.md(no section): es-ES summary added with-->stripped, fr-FR skipped with a log line.🤖 Generated with Claude Code