Skip to content

feat: show the update notice's highlight in Portuguese, and in any language with a changelog - #158

Merged
lippdev merged 2 commits into
mainfrom
feat/localized-update-summary
Oct 19, 2026
Merged

lippdev merged 2 commits into
mainfrom
feat/localized-update-summary

Conversation

@lippdev

@lippdev lippdev commented Oct 19, 2026

Copy link
Copy Markdown
Owner

Why

The update notice shows the first item of the release notes. Since 1.5.0-beta.6 the release body is English only (the Portuguese changelog is linked, not pasted), so every user, Portuguese ones included, reads "What's new" in English. Spanish, German, French and Russian users too, with no way to change that short of rewriting the release format.

What

  • release.yml: after the notes, the body gets one hidden line per translated changelog:
    <!-- summary pt-BR: Minimizar para a bandeja: … (#150) -->
    • pt-BR comes from CHANGELOG.md (already required).
    • Any CHANGELOG.<code>.md (e.g. a future CHANGELOG.es-ES.md) is picked up on its own; if it lacks the version's section it is skipped with a log line, never failing the release.
    • --> inside an item is removed so it can't close the comment early.
    • GitHub doesn't render HTML comments, so the visible release page is unchanged.
  • ReleaseNotes.FirstLine: uses the summary for the exact interface language when there is one, otherwise the current behavior (the English first item). Markdown links now show as their text (u/Skinner99 instead of [u/Skinner99](https://…)) in both paths.

Compatibility: the summaries sit at the very end of the body, after the "Notas em português" line. Clients up to 1.6.x show the first line they find, so they keep showing the English item. Covered by Summaries_StayAfterTheNotesForOlderClients.

The effect shows from the first release published after this, read by clients that include it (so: 1.7.0 users updating to 1.7.x).

Testing

  • dotnet test: 415 passed (4 new: summary wins for its language, CRLF, other languages fall back to English, empty or unclosed summary falls back, summaries stay after the notes).
  • Ran the workflow step itself locally in PowerShell 7.4 with VERSION=1.6.2 against the real changelogs: the body is identical up to the Portuguese link, then gets the pt-BR summary. With a fake CHANGELOG.es-ES.md (has the section, contains -->) and CHANGELOG.fr-FR.md (no section): es-ES summary added with --> stripped, fr-FR skipped with a log line.
  • The Windows build is left to CI. Nothing to check by hand beyond the update notice on the next release.

🤖 Generated with Claude Code

lippdev and others added 2 commits October 19, 2026 18:41
…nguage with a changelog

Since 1.5.0-beta.6 the release body is English only, so everyone, Portuguese
users included, read the update notice in English. The release workflow now
appends one hidden <!-- summary <code>: ... --> line per translated changelog
(CHANGELOG.md for pt-BR, any CHANGELOG.<code>.md for another language), after
the notes so older clients still show the English item. ReleaseNotes.FirstLine
prefers the summary for the interface language and strips Markdown links.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes This review covers localized update-highlight generation and display, including release-note parsing and changelog entries.

  • Release summaries The release workflow appends hidden summaries for Portuguese and optional translated changelogs while preserving the visible release body and the English fallback.
  • Update notice parsing ReleaseNotes.FirstLine selects a summary matching the exact interface language, cleans basic Markdown formatting, and falls back to the existing notes parser when absent or invalid.
  • Compatibility and coverage Summaries remain after the visible notes for older clients; tests cover language selection, CRLF, fallback, and malformed summaries.

Pullfrog  | View workflow run | Using gpt-6-luna | 𝕏

@lippdev
lippdev merged commit de04e7c into main Oct 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant