Skip to content

feat: pinned ControlFS file explorer panel in the session menu - #122

Merged
lippdev merged 6 commits into
mainfrom
feat/controlfs-explorer
Sep 30, 2026
Merged

lippdev merged 6 commits into
mainfrom
feat/controlfs-explorer

Conversation

@lippdev

@lippdev lippdev commented Sep 30, 2026

Copy link
Copy Markdown
Owner

Stacked on #120. A pinned panel at the top of the session menu's side column opens ControlFS (the team's controller-first file explorer) on the session screen, always full screen. It is found through Windows' program list, opened only when no window exists (otherwise brought forward, since a second --start left a second copy running), never killed; without it installed, its release page opens.

Build left to CI (Windows only); unit tests pass locally and the flow was run by hand on the dev machine. Manual checks: docs/TESTING.md section 1d.

🤖 Generated with Claude Code

lippdev and others added 3 commits September 30, 2026 17:41
Finds the installed ControlFS (registry, LocalAppData, Program Files), opens
it with its own --start flag (never kills it) and falls back to its release
page when it is not installed.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
It has no start-up flag for it, so the window is found, moved to the session
screen and F11 is sent when it does not cover the screen exactly (maximized
as fallback). An open window is only brought forward: starting it again left
a second copy running.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Please address the two concrete issues below before merging.

Reviewed changes This review covers the ControlFS session-menu integration, executable discovery, display/fullscreen handling, localization, and locator tests.

  • Pinned session-menu entry Adds a fixed ControlFS action that opens the app or its release page when it is not installed.
  • ControlFS launch and display handling Locates the executable from registry and conventional install folders, then attempts to foreground and fullscreen its window on the session display.
  • Localization and tests Adds the row strings in all three catalogs, manual test steps, and pure locator coverage.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using GPT Luna | 𝕏

Comment thread tests/ConsoleMode.Tests/ControlFsLocatorTests.cs Outdated
Comment thread src/ConsoleMode/Services/ControlFsService.cs Outdated

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes This review covers the commits added since the prior Pullfrog review, including the foreground-focus guard, cross-platform locator test adjustment, and related documentation updates.

  • Guarded fullscreen input Skipped F11 unless ControlFS is confirmed to be the foreground window after activation is requested.
  • Made locator tests platform-aware Built fixture paths with the runtime platform's path separator and joining rules; the unit suite passes on Linux (234 passed).
  • Documented focus-denial behavior Added the expected manual check and clarified the changelog behavior.

Pullfrog  | View workflow run | Using GPT Luna | 𝕏

@lippdev
lippdev changed the base branch from feat/session-menu-redesign to main September 30, 2026 21:53

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes This review covers the changes since the prior Pullfrog review, primarily the synchronization with the session-menu redesign and the resulting test-project updates.

  • Synchronized test coverage Linked the existing SteamShutdown logic into the test project; the English catalog resource remains included in the current project file.

Pullfrog  | View workflow run | Using GPT Luna | 𝕏

@lippdev
lippdev merged commit 7573095 into main Sep 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant