Repository navigation
feat: 1.6 is all our own code, no NirSoft fallback (#91) - #101
Merged
Merged
Conversation
- Remove the MultiMonitorTool and SoundVolumeView backends, the NativeAudio / NativeDisplays flags, their paths, the "tool missing" strings (three catalogs), the SoundVolumeView volume parser and CsvReader. - MonitorService talks to a single DisplayBackend (Windows APIs only); AudioService uses Core Audio only. - On startup, delete the MultiMonitorTool.exe / SoundVolumeView.exe that 1.5 extracted into the tools folder. - Checklist and changelog updated. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes This review covers the removal of NirSoft backends and the resulting unconditional use of the existing Windows-native display and audio implementations.
- Backend selection removed The
NativeAudioandNativeDisplaysflags, NirSoft process paths, and backend-selection code are removed, making Core Audio and Windows display APIs the sole implementations. - Legacy tool cleanup Startup removes old NirSoft executables from the tools directory while retaining RTSS CLI setup.
- Display identity and restoration retained The native display backend continues to use the legacy layout format and maps saved monitor identities during restore.
- Documentation and cleanup The unused SoundVolumeView CSV parser and test are removed, while the manual checklist and Unreleased changelogs are updated for 1.5-to-1.6 upgrades.
GPT Luna | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Removes every trace of the NirSoft tools from the app, as decided for 1.6:
NativeAudio/NativeDisplaysflags, the tool paths and the "tool missing" strings are gone.MonitorServiceuses a singleDisplayBackend(Windows APIs);AudioServiceuses Core Audio only.CsvReader.MultiMonitorTool.exe/SoundVolumeView.exethat 1.5 extracted intotools.Still not verified on hardware.
🤖 Generated with Claude Code